Bug 186965 – transform-origin should not accept 4 lengths

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Eric Willigers]

transform-origin accepts 1, 2, or 3 values.
https://drafts.csswg.org/css-transforms/#propdef-transform-origin

Unfortunately, WebKit allows '1px 2px 3px 4x' and silently discards the last length.

Example:
http://jsfiddle.net/ericwilligers/me38g7ax/

Found while preparing Web Platform Test
https://github.com/web-platform-tests/wpt/pull/11633

[Joonghun Park]

Created attachment 438040 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 438040 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438040&action=review

> Source/WebCore/css/parser/CSSPropertyParser.cpp:6139
> +        return consumeTransformOrigin(important) && m_range.atEnd();

I think the range.atEnd() check should move inside consumeTransformOrigin().

[Joonghun Park]

(In reply to Simon Fraser (smfr) from comment #2)
> Comment on attachment 438040 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=438040&action=review
> 
> > Source/WebCore/css/parser/CSSPropertyParser.cpp:6139
> > +        return consumeTransformOrigin(important) && m_range.atEnd();
> 
> I think the range.atEnd() check should move inside consumeTransformOrigin().

Ok, I will move the range.atEnd() into consumeTransformOrigin().

[Joonghun Park]

Created attachment 438045 [details]
Move range.atEnd() into consumeTransformOrigin()

[EWS]

Committed r282359 (241622@main): <https://commits.webkit.org/241622@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 438045 [details].

[Radar WebKit Bug Importer]

<rdar://problem/83072923>