186955 – [ews-build] Add support for Style-EWS

RESOLVED FIXED 186955

[ews-build] Add support for Style-EWS

https://bugs.webkit.org/show_bug.cgi?id=186955

Summary [ews-build] Add support for Style-EWS

Aakash Jain

Reported 2018-06-22 17:59:38 PDT

We should add build steps for Style-EWS.

Attachments
Proposed patch (19.28 KB, patch) 2018-06-22 18:45 PDT, Aakash Jain	lforschler: review+ ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews204 for win-future (12.75 MB, application/zip) 2018-06-23 10:54 PDT, EWS Watchlist	no flags	Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Aakash Jain

Comment 1 2018-06-22 18:45:59 PDT

Created attachment 343413 [details] Proposed patch This is similar to what we use in other Buildbot code for pre-commit testing. Also tested on ews-build.webkit-uat.org (http://ews-build.webkit-uat.org/#/builders/5/builds/5)

EWS Watchlist

Comment 2 2018-06-22 18:48:15 PDT Comment hidden (obsolete)

Attachment 343413 [details] did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:30: No name 'internet' in module 'twisted' [pylint/E0611] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:31: No name 'python' in module 'twisted' [pylint/E0611] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:32: No name 'trial' in module 'twisted' [pylint/E0611] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:39: [BuildStepMixinAdditions.setUpBuildStep] Instance of 'BuildStepMixinAdditions' has no 'patch' member [pylint/E1101] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:94: [BuildStepMixinAdditions._checkSpawnProcess] Instance of 'BuildStepMixinAdditions' has no 'fail' member [pylint/E1101] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:97: [BuildStepMixinAdditions._checkSpawnProcess] Instance of 'BuildStepMixinAdditions' has no 'assertEqual' member [pylint/E1101] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:124: [BuildStepMixinAdditions.runStep.check] Instance of 'BuildStepMixinAdditions' has no 'assertEqual' member [pylint/E1101] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:126: [BuildStepMixinAdditions.runStep.check] Instance of 'BuildStepMixinAdditions' has no 'assertEqual' member [pylint/E1101] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:129: [BuildStepMixinAdditions.runStep.check] Instance of 'FakeBuild' has no 'sources' member [pylint/E1101] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:131: [BuildStepMixinAdditions.runStep.check] Instance of 'BuildStepMixinAdditions' has no 'assertEqual' member [pylint/E1101] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:146: [TestCheckStyle.test_success_internal] Undefined variable 'CheckStyle' [pylint/E0602] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:157: [TestCheckStyle.test_success_internal] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:157: [TestCheckStyle.test_success_internal] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:157: [TestCheckStyle.test_success_internal] Undefined variable 'SUCCESS' [pylint/E0602] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:161: [TestCheckStyle.test_failure_unknown_try_codebase] Undefined variable 'CheckStyle' [pylint/E0602] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:172: [TestCheckStyle.test_failure_unknown_try_codebase] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:172: [TestCheckStyle.test_failure_unknown_try_codebase] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:172: [TestCheckStyle.test_failure_unknown_try_codebase] Undefined variable 'FAILURE' [pylint/E0602] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:176: [TestCheckStyle.test_failures_with_style_issues] Undefined variable 'CheckStyle' [pylint/E0602] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:194: [TestCheckStyle.test_failures_with_style_issues] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:194: [TestCheckStyle.test_failures_with_style_issues] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:194: [TestCheckStyle.test_failures_with_style_issues] Undefined variable 'FAILURE' [pylint/E0602] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:198: [TestCheckStyle.test_failures_no_style_issues] Undefined variable 'CheckStyle' [pylint/E0602] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:210: [TestCheckStyle.test_failures_no_style_issues] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:210: [TestCheckStyle.test_failures_no_style_issues] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:210: [TestCheckStyle.test_failures_no_style_issues] Undefined variable 'SUCCESS' [pylint/E0602] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:214: [TestCheckStyle.test_failures_no_changes] Undefined variable 'CheckStyle' [pylint/E0602] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:226: [TestCheckStyle.test_failures_no_changes] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:226: [TestCheckStyle.test_failures_no_changes] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:226: [TestCheckStyle.test_failures_no_changes] Undefined variable 'FAILURE' [pylint/E0602] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:24: No name 'results' in module 'buildbot.process' [pylint/E0611] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:27: No name 'internet' in module 'twisted' [pylint/E0611] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:35: [ConfigureBuild.__init__] Use of super on an old style class [pylint/E1002] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:60: [CheckOutSource.__init__] Use of super on an old style class [pylint/E1002] [5] Total errors found: 34 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.

EWS Watchlist

Comment 3 2018-06-23 10:54:00 PDT Comment hidden (obsolete)

Comment on attachment 343413 [details] Proposed patch Attachment 343413 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8305813 New failing tests: http/tests/security/canvas-remote-read-remote-video-blocked-no-crossorigin.html

EWS Watchlist

Comment 4 2018-06-23 10:54:11 PDT Comment hidden (obsolete)

Created attachment 343443 [details] Archive of layout-test-results from ews204 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews204 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

Lucas Forschler

Comment 5 2018-06-25 12:24:06 PDT

Comment on attachment 343413 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=343413&action=review > Tools/BuildSlaveSupport/ews-build/steps.py:38 > + if platform != 'jsc-only': do we expect to have this for EWS?

Lucas Forschler

Comment 6 2018-06-25 12:24:28 PDT

please address any style check issues before landing.

Aakash Jain

Comment 7 2018-06-25 12:55:37 PDT

View in context: https://bugs.webkit.org/attachment.cgi?id=343413&action=review >> Tools/BuildSlaveSupport/ews-build/steps.py:38 >> + if platform != 'jsc-only': > > do we expect to have this for EWS? long-term plan is to share the code between build.webkit.org and ews-build.webkit.org (once we upgrade build.webkit.org to latest buildbot). While writing this code I am keeping build.webkit.org in mind. > please address any style check issues before landing. Sure, although most of them are false positive.

Aakash Jain

Comment 8 2018-06-25 13:01:50 PDT

Committed r233166: <https://trac.webkit.org/changeset/233166>

Radar WebKit Bug Importer

Comment 9 2018-06-25 13:08:46 PDT

<rdar://problem/41436534>

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version Other

Hardware Unspecified

OS Unspecified

Product WebKit

Component Tools / Tests

Assignee

Aakash Jain

Reported

2018-06-22 17:59 PDT

Modified

2018-06-25 13:08 PDT History

CC List

5 users Show

URL

Keywords InRadar

Depends on

Blocks