Bug 186952 – Adjust webrtc library for LTO

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[Keith Rollin]

There are a number of files in webrtc that have main() functions (in particular, rtpcat.cc and click_annotate.cc). When compiling with LTO, these symbols are exposed to each other, leading to the following build failure:

Ld libwebrtc.dylib
duplicate symbol _main in:
ld: 1 duplicate symbol for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
** BUILD FAILED **

Address this by removing the indicated files from the build.

[Radar WebKit Bug Importer]

<rdar://problem/41387815>

[youenn fablet]

For now, we should just stop compiling these files.
They were included to be able to run some libwebrtc tests IIRC but we are not yet running them anyway.

[Keith Rollin]

Created attachment 343407 [details]
Patch

[Keith Rollin]

Youenn, I'd gone ahead and removed the files before I saw your comment. If you really want them included in the project but disabled, let me know.

[EWS Watchlist]

Comment on attachment 343407 [details]
Patch

Attachment 343407 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8309105

New failing tests:
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-audio.html

[EWS Watchlist]

Created attachment 343462 [details]
Archive of layout-test-results from ews202 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews202  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[WebKit Commit Bot]

Comment on attachment 343407 [details]
Patch

Clearing flags on attachment: 343407

Committed r233155: <https://trac.webkit.org/changeset/233155>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.