Bug 186948 - [ews-build] Add support for try Buildbot try schedulers
Summary: [ews-build] Add support for try Buildbot try schedulers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-22 16:23 PDT by Aakash Jain
Modified: 2018-06-25 11:55 PDT (History)
6 users (show)

See Also:


Attachments
Proposed patch (3.16 KB, patch)
2018-06-22 16:45 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews206 for win-future (12.75 MB, application/zip)
2018-06-23 13:56 PDT, EWS Watchlist
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2018-06-22 16:23:18 PDT
OpenSource EWS (http://ews-build.webkit-uat.org/) should have support for try schedulers. Try scheduler are provided by Buildbot, and they allow running builds on a patch (as opposed to svn commit).

Reference: https://docs.buildbot.net/current/manual/cfg-schedulers.html#try-schedulers
Comment 1 Aakash Jain 2018-06-22 16:45:56 PDT
Created attachment 343395 [details]
Proposed patch

This is similar to what we use in other Buildbot code for pre-commit testing.
Comment 2 EWS Watchlist 2018-06-23 13:55:51 PDT Comment hidden (obsolete)
Comment 3 EWS Watchlist 2018-06-23 13:56:02 PDT Comment hidden (obsolete)
Comment 4 Lucas Forschler 2018-06-25 11:19:12 PDT
Comment on attachment 343395 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343395&action=review

> Tools/BuildSlaveSupport/ews-build/loadConfig.py:73
> +        c['schedulers'].append(schedulerClass(**scheduler))

How are we going to configure secure names/passwords for this? does it load them from a secure location on disk?
Comment 5 Aakash Jain 2018-06-25 11:50:06 PDT
> How are we going to configure secure names/passwords for this? does it load
> them from a secure location on disk?

Added a FIXME to read the credentials from disk.
Comment 6 Aakash Jain 2018-06-25 11:53:23 PDT
Committed r233160: <https://trac.webkit.org/changeset/233160>
Comment 7 Radar WebKit Bug Importer 2018-06-25 11:55:35 PDT
<rdar://problem/41433648>