WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
186948
[ews-build] Add support for try Buildbot try schedulers
https://bugs.webkit.org/show_bug.cgi?id=186948
Summary
[ews-build] Add support for try Buildbot try schedulers
Aakash Jain
Reported
2018-06-22 16:23:18 PDT
OpenSource EWS (
http://ews-build.webkit-uat.org/
) should have support for try schedulers. Try scheduler are provided by Buildbot, and they allow running builds on a patch (as opposed to svn commit). Reference:
https://docs.buildbot.net/current/manual/cfg-schedulers.html#try-schedulers
Attachments
Proposed patch
(3.16 KB, patch)
2018-06-22 16:45 PDT
,
Aakash Jain
no flags
Details
Formatted Diff
Diff
Archive of layout-test-results from ews206 for win-future
(12.75 MB, application/zip)
2018-06-23 13:56 PDT
,
EWS Watchlist
no flags
Details
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Aakash Jain
Comment 1
2018-06-22 16:45:56 PDT
Created
attachment 343395
[details]
Proposed patch This is similar to what we use in other Buildbot code for pre-commit testing.
EWS Watchlist
Comment 2
2018-06-23 13:55:51 PDT
Comment hidden (obsolete)
Comment on
attachment 343395
[details]
Proposed patch
Attachment 343395
[details]
did not pass win-ews (win): Output:
https://webkit-queues.webkit.org/results/8306853
New failing tests: http/tests/security/contentSecurityPolicy/video-with-https-url-allowed-by-csp-media-src-star.html
EWS Watchlist
Comment 3
2018-06-23 13:56:02 PDT
Comment hidden (obsolete)
Created
attachment 343448
[details]
Archive of layout-test-results from ews206 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews206 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Lucas Forschler
Comment 4
2018-06-25 11:19:12 PDT
Comment on
attachment 343395
[details]
Proposed patch View in context:
https://bugs.webkit.org/attachment.cgi?id=343395&action=review
> Tools/BuildSlaveSupport/ews-build/loadConfig.py:73 > + c['schedulers'].append(schedulerClass(**scheduler))
How are we going to configure secure names/passwords for this? does it load them from a secure location on disk?
Aakash Jain
Comment 5
2018-06-25 11:50:06 PDT
> How are we going to configure secure names/passwords for this? does it load > them from a secure location on disk?
Added a FIXME to read the credentials from disk.
Aakash Jain
Comment 6
2018-06-25 11:53:23 PDT
Committed
r233160
: <
https://trac.webkit.org/changeset/233160
>
Radar WebKit Bug Importer
Comment 7
2018-06-25 11:55:35 PDT
<
rdar://problem/41433648
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug