RESOLVED FIXED 186943
PropertyCondition::isValidValueForAttributes() should also consider deleted values. 
https://bugs.webkit.org/show_bug.cgi?id=186943
Summary PropertyCondition::isValidValueForAttributes() should also consider deleted v...
Mark Lam
Reported 2018-06-22 14:47:44 PDT
PropertyCondition::isValidValueForAttributes() should check if the passed in value is a deleted one before it does a jsDynamicCast on it. <rdar://problem/41370337>
Attachments
proposed patch. (3.96 KB, patch)
2018-06-22 15:02 PDT, Mark Lam 		no flags
DetailsFormatted DiffDiff
proposed patch. (4.11 KB, patch)
2018-06-22 15:20 PDT, Mark Lam 		no flags
DetailsFormatted DiffDiff
proposed patch. (4.21 KB, patch)
2018-06-22 15:31 PDT, Mark Lam 		no flags
DetailsFormatted DiffDiff
proposed patch. (3.12 KB, patch)
2018-06-22 15:45 PDT, Mark Lam 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2018-06-22 15:02:19 PDT
Created attachment 343372 [details] proposed patch.
Mark Lam
Comment 2 2018-06-22 15:20:15 PDT
Created attachment 343374 [details] proposed patch.
Mark Lam
Comment 3 2018-06-22 15:31:04 PDT
Created attachment 343375 [details] proposed patch.
Mark Lam
Comment 4 2018-06-22 15:45:41 PDT
Created attachment 343381 [details] proposed patch.
Mark Lam
Comment 5 2018-06-22 17:17:47 PDT
Comment on attachment 343381 [details] proposed patch. Thanks for the review.
WebKit Commit Bot
Comment 6 2018-06-22 17:45:12 PDT
Comment on attachment 343381 [details] proposed patch. Clearing flags on attachment: 343381 Committed r233114: <https://trac.webkit.org/changeset/233114>
WebKit Commit Bot
Comment 7 2018-06-22 17:45:14 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.