Bug 186941 – Do not do early processing of incoming sync IPC unless we're waiting for a sync IPC reply

• Status: RESOLVED
• Resolution: INVALID
• Component: WebKit2

[Chris Dumez]

Do not do early processing of incoming sync IPC unless we're waiting for a sync IPC reply.

[Chris Dumez]

Created attachment 343366 [details]
WIP Patch

[Chris Dumez]

Created attachment 343367 [details]
Patch

[EWS Watchlist]

Comment on attachment 343367 [details]
Patch

Attachment 343367 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/8296126

New failing tests:
plugins/update-widgets-crash.html

[EWS Watchlist]

Created attachment 343376 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[Chris Dumez]

Created attachment 343384 [details]
Patch

[EWS Watchlist]

Comment on attachment 343384 [details]
Patch

Attachment 343384 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8300781

New failing tests:
http/tests/misc/blob-size.html

[EWS Watchlist]

Created attachment 343421 [details]
Archive of layout-test-results from ews201 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews201  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[Chris Dumez]

Created attachment 350429 [details]
Patch

[EWS Watchlist]

Comment on attachment 350429 [details]
Patch

Attachment 350429 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/9305449

New failing tests:
http/tests/misc/blob-size.html

[EWS Watchlist]

Created attachment 350467 [details]
Archive of layout-test-results from ews206 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[Chris Dumez]

My new test is crashing on Windows but the attached archive does not contain a crash trace :/

Also note that my code change is WebKit2-specific so it is merely my new test findings a pre-existing Windows port bug related to blobs.

[Chris Dumez]

Created attachment 350643 [details]
Patch

[Chris Dumez]

Comment on attachment 350643 [details]
Patch

Clearing flags on attachment: 350643

Committed r236420: <https://trac.webkit.org/changeset/236420>

[Chris Dumez]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/44736030>

[Chris Dumez]

Reverted r236420 and r236458 for reason:

This change is not fully correct

Committed r236487: <https://trac.webkit.org/changeset/236487>

[Chris Dumez]

Add too much complexity as it makes it so that 2 synchronous IPC messages may no longer get processed in order.