Bug 186935 - Expose colorFilterEnabled SPI in WKPreferencesPrivate
Summary: Expose colorFilterEnabled SPI in WKPreferencesPrivate
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-22 11:55 PDT by Luming Yin
Modified: 2018-06-22 13:21 PDT (History)
7 users (show)

See Also:

Attachments
Patch for bug 186935. (2.34 KB, patch)
2018-06-22 12:09 PDT, Luming Yin 		thorton: review-
Details | Formatted Diff | Diff
Updated patch for bug 186935. (2.35 KB, patch)
2018-06-22 12:17 PDT, Luming Yin 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Luming Yin 2018-06-22 11:55:16 PDT 
We should expose the colorFilterEnabled SPI in WKPreferencesPrivate.
Comment 1 Luming Yin 2018-06-22 12:09:58 PDT 
Created attachment 343350 [details]
Patch for bug 186935.
Comment 2 Tim Horton 2018-06-22 12:14:15 PDT 
Comment on attachment 343350 [details]
Patch for bug 186935.

View in context: https://bugs.webkit.org/attachment.cgi?id=343350&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h:140
> +@property (nonatomic, setter=_setColorFilterEnabled:) BOOL _colorFilterEnabled WK_API_AVAILABLE(macosx(WK_MAC_TBA));

Needs WK_IOS_TBA
Comment 3 Luming Yin 2018-06-22 12:17:01 PDT 
Created attachment 343351 [details]
Updated patch for bug 186935.
Comment 4 WebKit Commit Bot 2018-06-22 12:56:48 PDT 
Comment on attachment 343351 [details]
Updated patch for bug 186935.

Clearing flags on attachment: 343351

Committed r233089: <https://trac.webkit.org/changeset/233089>
Comment 5 WebKit Commit Bot 2018-06-22 12:56:49 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-06-22 12:57:20 PDT 
<rdar://problem/41378619>
Comment 7 Dawei Fenton (:realdawei) 2018-06-22 13:11:34 PDT 
Looks like this patch broke the iOS build

sample output:
https://build.webkit.org/builders/Apple%20iOS%2011%20Simulator%20Release%20%28Build%29/builds/6738/steps/compile-webkit/logs/stdio

** BUILD FAILED **


The following build commands failed:
	CompileC /Volumes/Data/slave/ios-simulator-11-release/build/WebKitBuild/WebKit.build/Release-iphonesimulator/WebKit.build/Objects-normal/x86_64/WKPreferences-77E55B3F73300247.o UIProcess/API/Cocoa/WKPreferences.mm normal x86_64 objective-c++ com.apple.compilers.llvm.clang.1_0.compiler
(1 failure)
Comment 8 Tim Horton 2018-06-22 13:17:38 PDT 
I’ll fix it.
Comment 9 Tim Horton 2018-06-22 13:21:29 PDT 
Build fix in https://trac.webkit.org/changeset/233094/webkit