Bug 186931 - Disable WebSocket in WatchOS
Summary: Disable WebSocket in WatchOS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-22 10:44 PDT by youenn fablet
Modified: 2018-06-22 23:14 PDT (History)
8 users (show)

See Also:

Attachments
Patch (5.91 KB, patch)
2018-06-22 10:51 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews113 for mac-sierra (3.15 MB, application/zip)
2018-06-22 12:22 PDT, EWS Watchlist 		no flags Details
Patch (5.30 KB, patch)
2018-06-22 14:10 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing, fixing path to testharness.js (5.33 KB, patch)
2018-06-22 16:21 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2018-06-22 10:44:17 PDT 
Not needed right now
Comment 1 youenn fablet 2018-06-22 10:44:46 PDT 
<rdar://problem/39584458>
Comment 2 youenn fablet 2018-06-22 10:51:03 PDT 
Created attachment 343344 [details]
Patch
Comment 3 Wenson Hsieh 2018-06-22 12:02:45 PDT 
+ jbedard

Do you remember if we can currently run http tests on watchOS? IIUC, running http tests on watch simulator is blocked by <rdar://problem/39141677>...
Comment 4 EWS Watchlist 2018-06-22 12:22:28 PDT 
Comment on attachment 343344 [details]
Patch

Attachment 343344 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/8293435

New failing tests:
performance-api/performance-observer-no-document-leak.html
Comment 5 EWS Watchlist 2018-06-22 12:22:29 PDT 
Created attachment 343353 [details]
Archive of layout-test-results from ews113 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 6 Wenson Hsieh 2018-06-22 12:56:52 PDT 
(In reply to Wenson Hsieh from comment #3)
> + jbedard
> 
> Do you remember if we can currently run http tests on watchOS? IIUC, running
> http tests on watch simulator is blocked by <rdar://problem/39141677>...

Jonathan confirmed this on IRC. Youenn, can we make this a non-http layout test?
Comment 7 youenn fablet 2018-06-22 12:58:26 PDT 
OK, I will move it some non http folder.
Comment 8 youenn fablet 2018-06-22 14:10:11 PDT 
Created attachment 343364 [details]
Patch
Comment 9 youenn fablet 2018-06-22 16:21:26 PDT 
Created attachment 343390 [details]
Patch for landing, fixing path to testharness.js
Comment 10 WebKit Commit Bot 2018-06-22 19:42:08 PDT 
Comment on attachment 343390 [details]
Patch for landing, fixing path to testharness.js

Clearing flags on attachment: 343390

Committed r233119: <https://trac.webkit.org/changeset/233119>
Comment 11 WebKit Commit Bot 2018-06-22 19:42:09 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 12 Alexey Proskuryakov 2018-06-22 23:11:42 PDT 
Comment on attachment 343390 [details]
Patch for landing, fixing path to testharness.js

View in context: https://bugs.webkit.org/attachment.cgi?id=343390&action=review

> LayoutTests/ChangeLog:11
> +        * fast/dom/Window/watchos/no-websocket-in-watchos.html: Added.

Are tests in this directory run in watchOS at all either?
Comment 13 Wenson Hsieh 2018-06-22 23:14:23 PDT 
(In reply to Alexey Proskuryakov from comment #12)
> Comment on attachment 343390 [details]
> Patch for landing, fixing path to testharness.js
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=343390&action=review
> 
> > LayoutTests/ChangeLog:11
> > +        * fast/dom/Window/watchos/no-websocket-in-watchos.html: Added.
> 
> Are tests in this directory run in watchOS at all either?

Test expectations for watchOS in our internal repo have:

fast/dom/Window/watchos [ Pass ]