Bug 186928 - We should call visitChildren on Base not the exact typename
Summary: We should call visitChildren on Base not the exact typename
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-22 10:01 PDT by Keith Miller
Modified: 2018-06-22 11:27 PDT (History)
6 users (show)

See Also:

Attachments
Patch (18.56 KB, patch)
2018-06-22 10:26 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
Patch for landing (18.56 KB, patch)
2018-06-22 10:33 PDT, Keith Miller 		keith_miller: commit-queue+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2018-06-22 10:01:22 PDT 
GetterSetter should call visitChildren on Base not JSCell
Comment 1 Keith Miller 2018-06-22 10:26:03 PDT 
Created attachment 343337 [details]
Patch
Comment 2 Mark Lam 2018-06-22 10:32:12 PDT 
Comment on attachment 343337 [details]
Patch

r=me
Comment 3 Keith Miller 2018-06-22 10:33:28 PDT 
Created attachment 343340 [details]
Patch for landing
Comment 4 Keith Miller 2018-06-22 11:26:46 PDT 
Committed r233085: <https://trac.webkit.org/changeset/233085>
Comment 5 Radar WebKit Bug Importer 2018-06-22 11:27:21 PDT 
<rdar://problem/41375075>