RESOLVED FIXED 186921
[GStreamer] Remove useless workaround 
https://bugs.webkit.org/show_bug.cgi?id=186921
Summary [GStreamer] Remove useless workaround
Philippe Normand
Reported 2018-06-22 08:26:51 PDT
In bug 67407 a workaround was added for GStreamer 0.10. With 1.x the media/video-reverse-play-duration.html test passes without any workaround needed. The other test mentioned in that bug was removed, it seems.
Attachments
Patch (1.89 KB, patch)
2018-06-22 08:28 PDT, Philippe Normand 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews117 for mac-sierra (3.01 MB, application/zip)
2018-06-22 11:49 PDT, EWS Watchlist 		no flags
Details
Archive of layout-test-results from ews202 for win-future (12.85 MB, application/zip)
2018-06-23 16:40 PDT, EWS Watchlist 		no flags
Details
Patch (2.96 KB, patch)
2018-07-06 04:57 PDT, Philippe Normand 		calvaris: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2018-06-22 08:28:47 PDT
Created attachment 343326 [details] Patch
EWS Watchlist
Comment 2 2018-06-22 11:49:22 PDT
Comment on attachment 343326 [details] Patch Attachment 343326 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/8293239 New failing tests: performance-api/performance-observer-no-document-leak.html
EWS Watchlist
Comment 3 2018-06-22 11:49:23 PDT
Created attachment 343349 [details] Archive of layout-test-results from ews117 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-sierra Platform: Mac OS X 10.12.6
EWS Watchlist
Comment 4 2018-06-23 16:40:09 PDT
Comment on attachment 343326 [details] Patch Attachment 343326 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8307969 New failing tests: http/tests/security/canvas-remote-read-remote-video-blocked-no-crossorigin.html
EWS Watchlist
Comment 5 2018-06-23 16:40:20 PDT
Created attachment 343458 [details] Archive of layout-test-results from ews202 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews202 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Philippe Normand
Comment 6 2018-06-25 03:59:12 PDT
Committed r233143: <https://trac.webkit.org/changeset/233143>
Radar WebKit Bug Importer
Comment 7 2018-06-25 04:01:53 PDT
<rdar://problem/41420581>
WebKit Commit Bot
Comment 8 2018-06-26 08:25:20 PDT
Re-opened since this is blocked by bug 187046
Philippe Normand
Comment 9 2018-07-05 02:23:13 PDT
media/video-ended-event-negative-playback.html breaks with this patch applied because currentMediaTime() chains to playbackPosition() which returns duration when EOS is reached, without running a POSITION query or checking the direction of playback.
Philippe Normand
Comment 10 2018-07-06 04:57:05 PDT
Created attachment 344421 [details] Patch
Philippe Normand
Comment 11 2018-07-09 01:15:59 PDT
Committed r233637: <https://trac.webkit.org/changeset/233637>
Note You need to log in before you can comment on or make changes to this bug.