Bug 186915 - [GTK] WebDriver: use a dictionary for session capabilities in StartAutomationSession message
Summary: [GTK] WebDriver: use a dictionary for session capabilities in StartAutomation...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2018-06-22 05:21 PDT by Carlos Garcia Campos
Modified: 2018-06-25 02:24 PDT (History)
9 users (show)

See Also:


Attachments
Patch (10.63 KB, patch)
2018-06-22 05:28 PDT, Carlos Garcia Campos
zan: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2018-06-22 05:21:52 PDT
Instead of growing the message signature every we add a new capability, use a dictionary a{sv} and simply add new entries when new capabilities are added. This way we won't need to change the message signature anymore. This broke the test webkit/WebKitAutomationSession/request-session because we changed the signature twice but we didn't update the test.
Comment 1 Carlos Garcia Campos 2018-06-22 05:28:16 PDT
Created attachment 343320 [details]
Patch
Comment 2 EWS Watchlist 2018-06-22 05:31:11 PDT
Attachment 343320 [details] did not pass style-queue:


ERROR: Source/WebDriver/glib/SessionHostGlib.cpp:287:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Carlos Garcia Campos 2018-06-22 06:24:04 PDT
Committed r233077: <https://trac.webkit.org/changeset/233077>