Bug 186914 - [WPE][ThreadedRendering] WPE crashes rendering SVG content when using ThreadedRendering
Summary: [WPE][ThreadedRendering] WPE crashes rendering SVG content when using Threade...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WPE WebKit (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Miguel Gomez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-06-22 02:02 PDT by Miguel Gomez
Modified: 2018-06-22 07:02 PDT (History)
6 users (show)

See Also:


Attachments
Patch (8.44 KB, patch)
2018-06-22 02:22 PDT, Miguel Gomez
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews100 for mac-sierra (2.28 MB, application/zip)
2018-06-22 03:29 PDT, EWS Watchlist
no flags Details
Patch (8.50 KB, patch)
2018-06-22 04:55 PDT, Miguel Gomez
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews114 for mac-sierra (3.00 MB, application/zip)
2018-06-22 06:30 PDT, EWS Watchlist
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Miguel Gomez 2018-06-22 02:02:21 PDT
Some SVG content uses GraphicsContext::clipToImageBuffer to define a clipping from the contents of an ImageBuffer. But GraphicsContextImpl doesn't have an implementation for this method so the call cannot be delegated and recorded. Instead, cairo GraphicsContext tries to perform cairo operations while in the recording state which causes the crash.
Comment 1 Miguel Gomez 2018-06-22 02:22:23 PDT
Created attachment 343315 [details]
Patch
Comment 2 EWS Watchlist 2018-06-22 03:29:05 PDT
Comment on attachment 343315 [details]
Patch

Attachment 343315 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/8288431

New failing tests:
performance-api/performance-observer-no-document-leak.html
Comment 3 EWS Watchlist 2018-06-22 03:29:06 PDT
Created attachment 343317 [details]
Archive of layout-test-results from ews100 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 4 Miguel Gomez 2018-06-22 04:55:00 PDT
Created attachment 343318 [details]
Patch
Comment 5 EWS Watchlist 2018-06-22 06:30:35 PDT
Comment on attachment 343318 [details]
Patch

Attachment 343318 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/8289544

New failing tests:
performance-api/performance-observer-no-document-leak.html
Comment 6 EWS Watchlist 2018-06-22 06:30:37 PDT
Created attachment 343323 [details]
Archive of layout-test-results from ews114 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 7 WebKit Commit Bot 2018-06-22 07:02:36 PDT
Comment on attachment 343318 [details]
Patch

Clearing flags on attachment: 343318

Committed r233078: <https://trac.webkit.org/changeset/233078>
Comment 8 WebKit Commit Bot 2018-06-22 07:02:37 PDT
All reviewed patches have been landed.  Closing bug.