Bug 186905 - Crash under WebResourceLoadStatisticsStore::mergeStatistics(WTF::Vector<WebCore::ResourceLoadStatistics, 0ul, WTF::CrashOnOverflow, 16ul>&&)
Summary: Crash under WebResourceLoadStatisticsStore::mergeStatistics(WTF::Vector<WebCo...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-21 19:08 PDT by Chris Dumez
Modified: 2018-06-22 13:16 PDT (History)
5 users (show)

See Also:

Attachments
Patch (17.07 KB, patch)
2018-06-21 19:26 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2018-06-21 19:08:56 PDT 
Crash under WebResourceLoadStatisticsStore::mergeStatistics(WTF::Vector<WebCore::ResourceLoadStatistics, 0ul, WTF::CrashOnOverflow, 16ul>&&):
      4 WebKit: WTF::HashTable<WTF::String, WTF::KeyValuePair<WTF::String, unsigned int>, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<WTF::String, unsigned int> >, WTF::StringHash, WTF::HashMap<WTF::String, unsigned int, WTF::StringHash, WTF::HashTraits<WTF::String>, WTF::HashTraits<unsigned int> >::KeyValuePairTraits, WTF::HashTraits<WTF::String> >::deallocateTable(WTF::KeyValuePair<WTF::String, unsigned int>*, unsigned int) <==
        3 WebKit: WTF::HashTable<WTF::String, WTF::KeyValuePair<WTF::String, unsigned int>, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<WTF::String, unsigned int> >, WTF::StringHash, WTF::HashMap<WTF::String, unsigned int, WTF::StringHash, WTF::HashTraits<WTF::String>, WTF::HashTraits<unsigned int> >::KeyValuePairTraits, WTF::HashTraits<WTF::String> >::operator=(WTF::HashTable<WTF::String, WTF::KeyValuePair<WTF::String, unsigned int>, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<WTF::String, unsigned int> >, WTF::StringHash, WTF::HashMap<WTF::String, unsigned int, WTF::StringHash, WTF::HashTraits<WTF::String>, WTF::HashTraits<unsigned int> >::KeyValuePairTraits, WTF::HashTraits<WTF::String> >&&)
        | 3 WebKit: WTF::HashTable<WTF::String, WTF::KeyValuePair<WTF::String, unsigned int>, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<WTF::String, unsigned int> >, WTF::StringHash, WTF::HashMap<WTF::String, unsigned int, WTF::StringHash, WTF::HashTraits<WTF::String>, WTF::HashTraits<unsigned int> >::KeyValuePairTraits, WTF::HashTraits<WTF::String> >::operator=(WTF::HashTable<WTF::String, WTF::KeyValuePair<WTF::String, unsigned int>, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<WTF::String, unsigned int> >, WTF::StringHash, WTF::HashMap<WTF::String, unsigned int, WTF::StringHash, WTF::HashTraits<WTF::String>, WTF::HashTraits<unsigned int> >::KeyValuePairTraits, WTF::HashTraits<WTF::String> >&&)
        |   3 WebKit: WebCore::ResourceLoadStatistics::operator=(WebCore::ResourceLoadStatistics&&)
        |     3 WebKit: WebKit::WebResourceLoadStatisticsStore::mergeStatistics(WTF::Vector<WebCore::ResourceLoadStatistics, 0ul, WTF::CrashOnOverflow, 16ul>&&)
        |       3 WebKit: WebKit::WebResourceLoadStatisticsStore::mergeWithDataFromDecoder(WebCore::KeyedDecoder&)
        |         3 WebKit: WebKit::ResourceLoadStatisticsPersistentStorage::refreshMemoryStoreFromDisk()
        |           3 libdispatch.dylib: _dispatch_client_callout
        |             pruning: 2 libdispatch.dylib: _dispatch_continuation_pop$VARIANT$armv81
        |             pruning: 1 libdispatch.dylib: _dispatch_continuation_pop$VARIANT$mp
        pruning: 1 WebKit: WebCore::ResourceLoadStatistics::~ResourceLoadStatistics()
Comment 1 Chris Dumez 2018-06-21 19:09:10 PDT 
<rdar://problem/41266775>
Comment 2 Chris Dumez 2018-06-21 19:26:28 PDT 
Created attachment 343301 [details]
Patch
Comment 3 Brent Fulgham 2018-06-22 12:34:11 PDT 
Comment on attachment 343301 [details]
Patch

This looks like a nice simplification. r=me.
Comment 4 WebKit Commit Bot 2018-06-22 13:16:38 PDT 
Comment on attachment 343301 [details]
Patch

Clearing flags on attachment: 343301

Committed r233092: <https://trac.webkit.org/changeset/233092>
Comment 5 WebKit Commit Bot 2018-06-22 13:16:39 PDT 
All reviewed patches have been landed.  Closing bug.