Bug 186901 - skip imported/w3c/web-platform-tests/css/css-display/display-contents-first-letter-002.html
Summary: skip imported/w3c/web-platform-tests/css/css-display/display-contents-first-l...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Keywords: InRadar
Depends on:
Reported: 2018-06-21 16:58 PDT by Dawei Fenton (:realdawei)
Modified: 2018-07-17 13:52 PDT (History)
4 users (show)

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description Dawei Fenton (:realdawei) 2018-06-21 16:58:50 PDT
temporarily Skipping imported/w3c/web-platform-tests/css/css-display/display-contents-first-letter-002.html because it has failed ever since it was merged.

sample results:

ASSERTION FAILED: !beforeChild || beforeChild->parent() == &parent
./rendering/updating/RenderTreeBuilder.cpp(404) : void WebCore::RenderTreeBuilder::attachToRenderElementInternal(WebCore::RenderElement &, RenderPtr<WebCore::RenderObject>, WebCore::RenderObject *)
1   0x10900ecc9 WTFCrash
2   0x1156b8038 WebCore::RenderTreeBuilder::attachToRenderElementInternal(WebCore::RenderElement&, std::__1::unique_ptr<WebCore::RenderObject, WebCore::RenderObjectDeleter>, WebCore::RenderObject*)
3   0x1156b2b93 WebCore::RenderTreeBuilder::attachToRenderElement(WebCore::RenderElement&, std::__1::unique_ptr<WebCore::RenderObject, WebCore::RenderObjectDeleter>, WebCore::RenderObject*)
4   0x1156b3f00 WebCore::RenderTreeBuilder::Inline::attachIgnoringContinuation(WebCore::RenderInline&, std::__1::unique_ptr<WebCore::RenderObject, WebCore::RenderObjectDeleter>,
Comment 1 zalan 2018-06-21 17:30:16 PDT
Didn't r233055 fix the assertion? (It still fails, I know, but the assertion should be all gone after r233055)
Comment 2 Dawei Fenton (:realdawei) 2018-06-21 17:35:01 PDT
(In reply to zalan from comment #1)
> Didn't r233055 fix the assertion? (It still fails, I know, but the assertion
> should be all gone after r233055)

Ah yes you're right. Assertion is gone, now it just fails.  I hold off on the skip
Comment 3 Ryan Haddad 2018-06-22 17:58:56 PDT
It looks like the test was skipped in https://trac.webkit.org/changeset/233069/webkit, so we should probably undo that.
Comment 4 Ryan Haddad 2018-07-17 13:51:11 PDT
Unskipped in https://trac.webkit.org/r233895
Comment 5 Radar WebKit Bug Importer 2018-07-17 13:52:19 PDT