RESOLVED CONFIGURATION CHANGED 186901
skip imported/w3c/web-platform-tests/css/css-display/display-contents-first-letter-002.html 
https://bugs.webkit.org/show_bug.cgi?id=186901
Summary skip imported/w3c/web-platform-tests/css/css-display/display-contents-first-l...
Dawei Fenton (:realdawei)
Reported 2018-06-21 16:58:50 PDT
temporarily Skipping imported/w3c/web-platform-tests/css/css-display/display-contents-first-letter-002.html because it has failed ever since it was merged. sample results: https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK1%20(Tests)/r233036%20(8249)/imported/w3c/web-platform-tests/css/css-display/display-contents-first-letter-002-stderr.txt ASSERTION FAILED: !beforeChild || beforeChild->parent() == &parent ./rendering/updating/RenderTreeBuilder.cpp(404) : void WebCore::RenderTreeBuilder::attachToRenderElementInternal(WebCore::RenderElement &, RenderPtr<WebCore::RenderObject>, WebCore::RenderObject *) 1 0x10900ecc9 WTFCrash 2 0x1156b8038 WebCore::RenderTreeBuilder::attachToRenderElementInternal(WebCore::RenderElement&, std::__1::unique_ptr<WebCore::RenderObject, WebCore::RenderObjectDeleter>, WebCore::RenderObject*) 3 0x1156b2b93 WebCore::RenderTreeBuilder::attachToRenderElement(WebCore::RenderElement&, std::__1::unique_ptr<WebCore::RenderObject, WebCore::RenderObjectDeleter>, WebCore::RenderObject*) 4 0x1156b3f00 WebCore::RenderTreeBuilder::Inline::attachIgnoringContinuation(WebCore::RenderInline&, std::__1::unique_ptr<WebCore::RenderObject, WebCore::RenderObjectDeleter>,
Attachments
Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2018-06-21 17:30:16 PDT
Didn't r233055 fix the assertion? (It still fails, I know, but the assertion should be all gone after r233055)
Dawei Fenton (:realdawei)
Comment 2 2018-06-21 17:35:01 PDT
(In reply to zalan from comment #1) > Didn't r233055 fix the assertion? (It still fails, I know, but the assertion > should be all gone after r233055) Ah yes you're right. Assertion is gone, now it just fails. I hold off on the skip
Ryan Haddad
Comment 3 2018-06-22 17:58:56 PDT
It looks like the test was skipped in https://trac.webkit.org/changeset/233069/webkit, so we should probably undo that.
Ryan Haddad
Comment 4 2018-07-17 13:51:11 PDT
Unskipped in https://trac.webkit.org/r233895
Radar WebKit Bug Importer
Comment 5 2018-07-17 13:52:19 PDT
<rdar://problem/42300426>
Note You need to log in before you can comment on or make changes to this bug.