RESOLVED FIXED 186899
Web Automation: key actions should support multiple pressed virtual keys 
https://bugs.webkit.org/show_bug.cgi?id=186899
Summary Web Automation: key actions should support multiple pressed virtual keys
Blaze Burg
Reported 2018-06-21 15:53:49 PDT
Right now, only one virtual key can be specified for an action keyframe. This prevents encoding a chord like Shift+Ctrl+A which has more than one modifier, or a sticky modifier with another key like F1 that's encoded as a VirtualKey in the protocol.
Attachments
Proposed Fix (24.48 KB, patch)
2018-06-21 16:46 PDT, Blaze Burg 		no flags
DetailsFormatted DiffDiff
Patch (fix EWS) (24.95 KB, patch)
2018-06-22 09:25 PDT, Blaze Burg 		timothy: review+
ews-watchlist: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews122 for ios-simulator-wk2 (8.41 MB, application/zip)
2018-06-22 10:58 PDT, EWS Watchlist 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Blaze Burg
Comment 1 2018-06-21 16:03:47 PDT
<rdar://problem/38222248>
Blaze Burg
Comment 2 2018-06-21 16:46:12 PDT
Created attachment 343289 [details] Proposed Fix Needs to be landed with internal changes.
Blaze Burg
Comment 3 2018-06-22 09:25:39 PDT
Created attachment 343331 [details] Patch (fix EWS)
EWS Watchlist
Comment 4 2018-06-22 10:58:03 PDT
Comment on attachment 343331 [details] Patch (fix EWS) Attachment 343331 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/8292088 New failing tests: performance-api/performance-observer-no-document-leak.html
EWS Watchlist
Comment 5 2018-06-22 10:58:05 PDT
Created attachment 343346 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4
Blaze Burg
Comment 6 2018-06-23 12:17:14 PDT
Committed r233131: <https://trac.webkit.org/changeset/233131>
Michael Catanzaro
Comment 7 2018-06-24 09:59:59 PDT
Committed r233133: <https://trac.webkit.org/changeset/233133>
Note You need to log in before you can comment on or make changes to this bug.