Bug 186899 - Web Automation: key actions should support multiple pressed virtual keys
Summary: Web Automation: key actions should support multiple pressed virtual keys
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebDriver (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: BJ Burg
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-21 15:53 PDT by BJ Burg
Modified: 2018-06-24 09:59 PDT (History)
7 users (show)

See Also:


Attachments
Proposed Fix (24.48 KB, patch)
2018-06-21 16:46 PDT, BJ Burg
no flags Details | Formatted Diff | Diff
Patch (fix EWS) (24.95 KB, patch)
2018-06-22 09:25 PDT, BJ Burg
timothy: review+
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews122 for ios-simulator-wk2 (8.41 MB, application/zip)
2018-06-22 10:58 PDT, EWS Watchlist
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2018-06-21 15:53:49 PDT
Right now, only one virtual key can be specified for an action keyframe. This prevents encoding a chord like Shift+Ctrl+A which has more than one modifier, or a sticky modifier with another key like F1 that's encoded as a VirtualKey in the protocol.
Comment 1 BJ Burg 2018-06-21 16:03:47 PDT
<rdar://problem/38222248>
Comment 2 BJ Burg 2018-06-21 16:46:12 PDT
Created attachment 343289 [details]
Proposed Fix

Needs to be landed with internal changes.
Comment 3 BJ Burg 2018-06-22 09:25:39 PDT
Created attachment 343331 [details]
Patch (fix EWS)
Comment 4 EWS Watchlist 2018-06-22 10:58:03 PDT
Comment on attachment 343331 [details]
Patch (fix EWS)

Attachment 343331 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/8292088

New failing tests:
performance-api/performance-observer-no-document-leak.html
Comment 5 EWS Watchlist 2018-06-22 10:58:05 PDT
Created attachment 343346 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.4
Comment 6 BJ Burg 2018-06-23 12:17:14 PDT
Committed r233131: <https://trac.webkit.org/changeset/233131>
Comment 7 Michael Catanzaro 2018-06-24 09:59:59 PDT
Committed r233133: <https://trac.webkit.org/changeset/233133>