Bug 186886 - [WPE][ThreadedRendering] WPE crashes rendering some pieces of text when using ThreadedRendering
Summary: [WPE][ThreadedRendering] WPE crashes rendering some pieces of text when using...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WPE WebKit (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Miguel Gomez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-06-21 03:25 PDT by Miguel Gomez
Modified: 2018-06-22 02:50 PDT (History)
4 users (show)

See Also:


Attachments
Patch (8.66 KB, patch)
2018-06-21 03:34 PDT, Miguel Gomez
no flags Details | Formatted Diff | Diff
Patch (8.62 KB, patch)
2018-06-22 01:03 PDT, Miguel Gomez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Miguel Gomez 2018-06-21 03:25:46 PDT
As an optimization, FontCascade may render some glyphs to a DisplayList and then replay that list instead of rendering again. But when replaying, the glyphs are not rendered through a GraphicsContext as we would expect, but using FontCascade directly. In the cairo case this means that FontCascade requires a cairo context to render, but if we are in the recording phase of the rendering there's no platform context and we have the crash.
Comment 1 Miguel Gomez 2018-06-21 03:34:51 PDT
Created attachment 343231 [details]
Patch
Comment 2 Miguel Gomez 2018-06-22 01:03:45 PDT
Created attachment 343313 [details]
Patch
Comment 3 WebKit Commit Bot 2018-06-22 02:50:01 PDT
Comment on attachment 343313 [details]
Patch

Clearing flags on attachment: 343313

Committed r233075: <https://trac.webkit.org/changeset/233075>
Comment 4 WebKit Commit Bot 2018-06-22 02:50:03 PDT
All reviewed patches have been landed.  Closing bug.