Bug 186885 - [GLIB] improve get_type() fast path in WEBKIT_DEFINE_TYPE
Summary: [GLIB] improve get_type() fast path in WEBKIT_DEFINE_TYPE
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Keywords: Gtk, InRadar
Depends on:
Reported: 2018-06-21 03:20 PDT by Carlos Garcia Campos
Modified: 2018-06-21 23:42 PDT (History)
11 users (show)

See Also:

Patch (3.75 KB, patch)
2018-06-21 03:25 PDT, Carlos Garcia Campos
no flags Details | Formatted Diff | Diff
Updated patch (4.11 KB, patch)
2018-06-21 03:57 PDT, Carlos Garcia Campos
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2018-06-21 03:20:39 PDT
This is a backport of glib commit https://gitlab.gnome.org/GNOME/glib/commit/e924f777369710221c3e0a9d7bf40392a27d1fa4.
Comment 1 Carlos Garcia Campos 2018-06-21 03:25:24 PDT
Created attachment 343230 [details]
Comment 2 Carlos Garcia Campos 2018-06-21 03:57:36 PDT
Created attachment 343232 [details]
Updated patch

Use NEVER_INLINE instead of G_GNUC_NO_INLINE to fix the build with older versions of glib.
Comment 3 Adrian Perez 2018-06-21 04:12:34 PDT
Comment on attachment 343232 [details]
Updated patch

It's lovely to see this change being ported to the WebKit macros. R+!
Comment 4 Carlos Garcia Campos 2018-06-21 23:41:23 PDT
Committed r233071: <https://trac.webkit.org/changeset/233071>
Comment 5 Radar WebKit Bug Importer 2018-06-21 23:42:19 PDT