Bug 186884 - [GTK] WebDriver: allow applying host-specific TLS certificates for automated sessions
Summary: [GTK] WebDriver: allow applying host-specific TLS certificates for automated ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-21 03:00 PDT by Zan Dobersek
Modified: 2018-06-21 04:04 PDT (History)
12 users (show)

See Also:

Attachments
Patch (12.63 KB, patch)
2018-06-21 03:17 PDT, Zan Dobersek 		cgarcia: review+
cgarcia: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2018-06-21 03:00:16 PDT 
[GTK] WebDriver: allow applying host-specific TLS certificates for automated sessions
Comment 1 Zan Dobersek 2018-06-21 03:17:12 PDT 
Created attachment 343229 [details]
Patch
Comment 2 EWS Watchlist 2018-06-21 03:18:57 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Carlos Garcia Campos 2018-06-21 03:41:19 PDT 
Comment on attachment 343229 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343229&action=review

> Source/JavaScriptCore/inspector/remote/glib/RemoteInspectorServer.cpp:135
> +            while (g_variant_iter_loop(certificates.get(), "(ss)", &host, &certificateFile))

You are getting copies here, you need to use "(&s&s)"
Comment 4 Zan Dobersek 2018-06-21 04:04:01 PDT 
Committed r233035: <https://trac.webkit.org/changeset/233035>
Comment 5 Radar WebKit Bug Importer 2018-06-21 04:04:19 PDT 
<rdar://problem/41324941>