186876 – Add force schedulers to OpenSource EWS Buildbot

Bug 186876 - Add force schedulers to OpenSource EWS Buildbot

Summary: Add force schedulers to OpenSource EWS Buildbot

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	Tools / Tests (show other bugs)
Version:	Other
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Aakash Jain

URL:
Keywords:	InRadar

Depends on:
Blocks:

Reported:	2018-06-20 20:58 PDT by Aakash Jain
Modified:	2019-04-01 10:06 PDT (History)
CC List:	6 users (show)

See Also:	196444

Attachments
Proposed patch (1.76 KB, patch) 2018-06-20 21:11 PDT, Aakash Jain	lforschler: review+	Details \| Formatted Diff \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Aakash Jain 2018-06-20 20:58:42 PDT

Builders on OpenSource EWS (e.g.: http://ews-build.webkit-uat.org/#/builders/5) currently do not have force schedulers, that's why there is no button on UI (webpage) to start a build. We should add force schedulers. This would help in testing and development as well as occasionally useful for forcing a build on a particular revision.

This would be similar to what we do in other similar Buildbot code for pre-commit testing.

Comment 1 Aakash Jain 2018-06-20 21:11:42 PDT

Created attachment 343210 [details]
Proposed patch

Comment 2 EWS Watchlist 2018-06-20 21:13:07 PDT Comment hidden (obsolete)

Attachment 343210 [details] did not pass style-queue:


ERROR: Tools/BuildSlaveSupport/ews-build/loadConfig.py:28:  No name 'WorkerChoiceParameter' in module 'buildbot.schedulers.forcesched'  [pylint/E0611] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Aakash Jain 2018-06-21 11:55:22 PDT

Committed r233045: <https://trac.webkit.org/changeset/233045>

Comment 4 Radar WebKit Bug Importer 2018-06-21 11:57:38 PDT

<rdar://problem/41338094>