Bug 186875 – [Cocoa] Use the isDirectory: variants of NSURL methods more to eliminate unnecessary file system activity

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Darin Adler]

[Cocoa] Use the isDirectory: variants of NSURL methods more to eliminate unnecessary file system activity

[Darin Adler]

Created attachment 343208 [details]
Patch

[Conrad Shultz]

Comment on attachment 343208 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343208&action=review

Looks good to me, though I can't r+.

> Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm:3962
> +    if (![wrapper writeToURL:[NSURL fileURLWithPath:path isDirectory:NO] options:NSFileWrapperWritingWithNameUpdating originalContentsURL:nil error:nullptr])

A few lines earlier, we use `m_promisedURL` when initializing the file wrapper, but use the plain `+URLWithString:`. It seems like `m_promisedURL` must also be a file URL, so should that be changed?

Since this is apparently used only for saving images, this change seems correct, but I'm a little wary since file wrappers can refer to directories.

[EWS Watchlist]

Comment on attachment 343208 [details]
Patch

Attachment 343208 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8275207

New failing tests:
http/tests/security/canvas-remote-read-remote-video-blocked-no-crossorigin.html

[EWS Watchlist]

Created attachment 343228 [details]
Archive of layout-test-results from ews202 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews202  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[Darin Adler]

Committed r233079: <https://trac.webkit.org/changeset/233079>

[Radar WebKit Bug Importer]

<rdar://problem/41368124>