Bug 186873 – JSPerformanceObserverCallback creates a GC strongly-referenced Function that is never cleaned up

• Status: RESOLVED
• Resolution: FIXED
• Component: Bindings

[Chris Dumez]

JSPerformanceObserverCallback creates a GC strongly-referenced Function that is never cleaned up.

[Chris Dumez]

<rdar://problem/41271574>

[Chris Dumez]

Created attachment 343205 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 343205 [details]
Patch

Nice but can we also add a test that the Document is not permanently leaked?

[Chris Dumez]

(In reply to Simon Fraser (smfr) from comment #3)
> Comment on attachment 343205 [details]
> Patch
> 
> Nice but can we also add a test that the Document is not permanently leaked?

Sure, how do I do that?

[Chris Dumez]

(In reply to Chris Dumez from comment #4)
> (In reply to Simon Fraser (smfr) from comment #3)
> > Comment on attachment 343205 [details]
> > Patch
> > 
> > Nice but can we also add a test that the Document is not permanently leaked?
> 
> Sure, how do I do that?

Just found internals.numberOfLiveDocuments(), will try this.

[Chris Dumez]

Created attachment 343247 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 343247 [details]
Patch

Clearing flags on attachment: 343247

Committed r233053: <https://trac.webkit.org/changeset/233053>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Dawei Fenton (:realdawei)]

Looks like test performance-api/performance-observer-no-document-leak.html is timing out on all platforms:

Flakiness Dashboard:
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=performance-api%2Fperformance-observer-no-document-leak.html

Sample results:
https://build.webkit.org/builders/Apple%20High%20Sierra%20Release%20WK1%20(Tests)/builds/6137/steps/layout-test/logs/stdio

Regressions: Unexpected timeouts (1)
  performance-api/performance-observer-no-document-leak.html [ Timeout ]