Bug 186871 - Add support for using localhost worker in OpenSource EWS Buildbot
Summary: Add support for using localhost worker in OpenSource EWS Buildbot
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-20 19:22 PDT by Aakash Jain
Modified: 2021-04-14 08:47 PDT (History)
6 users (show)

See Also:


Attachments
Proposed patch (2.68 KB, patch)
2018-06-20 19:31 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews122 for ios-simulator-wk2 (2.26 MB, application/zip)
2018-06-20 21:19 PDT, EWS Watchlist
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2018-06-20 19:22:28 PDT
Add support for using localhost worker in OpenSource EWS (http://ews-build.webkit-uat.org) so as to ease testing and development. This is similar to what we do in other similar Buildbot related code.
Comment 1 Aakash Jain 2018-06-20 19:31:00 PDT
Created attachment 343200 [details]
Proposed patch
Comment 2 EWS Watchlist 2018-06-20 21:19:19 PDT Comment hidden (obsolete)
Comment 3 EWS Watchlist 2018-06-20 21:19:20 PDT Comment hidden (obsolete)
Comment 4 Lucas Forschler 2018-06-21 11:12:01 PDT
Comment on attachment 343200 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343200&action=review

> Tools/BuildSlaveSupport/ews-build/master.cfg:4
>  

Can you put this in sorted order?
Comment 5 Aakash Jain 2018-06-21 11:26:32 PDT
> Can you put this in sorted order?

This was not sorted intentionally, in order to separate standard library import from and importing our files. Similar to what we do in other places, e.g.:
https://trac.webkit.org/browser/webkit/trunk/Tools/BuildSlaveSupport/build.webkit.org-config/loadConfig.py#L31

https://www.python.org/dev/peps/pep-0008/#imports
PEP8: 
Imports should be grouped in the following order:

Standard library imports.
Related third party imports.
Local application/library specific imports.
Comment 6 Aakash Jain 2018-06-21 11:53:52 PDT
Committed r233047: <https://trac.webkit.org/changeset/233047>
Comment 7 Radar WebKit Bug Importer 2018-06-21 11:54:20 PDT
<rdar://problem/41337971>