Bug 186867 - Web Inspector: All non-Same-Site cookies are marked as Same-Site Strict in Storage tab
Summary: Web Inspector: All non-Same-Site cookies are marked as Same-Site Strict in St...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-20 16:46 PDT by Daniel Bates
Modified: 2018-06-20 17:09 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.38 KB, patch)
2018-06-20 16:58 PDT, Daniel Bates 		mattbaker: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2018-06-20 16:46:54 PDT 
Steps to reproduce:

1. Open a new browser window and open Web Inspector to the storage tab.
2. Visit http://gmail.com.
3. Login.
4. In Web Inspector, click Cookies form the right-hand side.

At the time of writing there should be exactly two cookies GMAIL_RTT and GAPS that are not same-site cookies. That is the value of the Same-Site column should be empty.
Comment 1 Daniel Bates 2018-06-20 16:47:11 PDT 
<rdar://problem/41175424>
Comment 2 Daniel Bates 2018-06-20 16:58:46 PDT 
Created attachment 343192 [details]
Patch
Comment 3 Matt Baker 2018-06-20 17:03:39 PDT 
Comment on attachment 343192 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343192&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/CookieStorageContentView.js:143
> +                sameSite: !cookie.sameSite || cookie.sameSite === WI.Cookie.SameSiteType.None ? "" : WI.Cookie.displayNameForSameSiteType(cookie.sameSite),

I think this reads better as:

sameSite: cookie.sameSite && cookie.sameSite !== WI.Cookie.SameSiteType.None ? WI.Cookie.displayNameForSameSiteType(cookie.sameSite) : "",
Comment 4 Daniel Bates 2018-06-20 17:09:12 PDT 
Committed r233027: <https://trac.webkit.org/changeset/233027>