WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
186867
Web Inspector: All non-Same-Site cookies are marked as Same-Site Strict in Storage tab
https://bugs.webkit.org/show_bug.cgi?id=186867
Summary
Web Inspector: All non-Same-Site cookies are marked as Same-Site Strict in St...
Daniel Bates
Reported
2018-06-20 16:46:54 PDT
Steps to reproduce: 1. Open a new browser window and open Web Inspector to the storage tab. 2. Visit
http://gmail.com
. 3. Login. 4. In Web Inspector, click Cookies form the right-hand side. At the time of writing there should be exactly two cookies GMAIL_RTT and GAPS that are not same-site cookies. That is the value of the Same-Site column should be empty.
Attachments
Patch
(2.38 KB, patch)
2018-06-20 16:58 PDT
,
Daniel Bates
mattbaker
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Daniel Bates
Comment 1
2018-06-20 16:47:11 PDT
<
rdar://problem/41175424
>
Daniel Bates
Comment 2
2018-06-20 16:58:46 PDT
Created
attachment 343192
[details]
Patch
Matt Baker
Comment 3
2018-06-20 17:03:39 PDT
Comment on
attachment 343192
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=343192&action=review
r=me
> Source/WebInspectorUI/UserInterface/Views/CookieStorageContentView.js:143 > + sameSite: !cookie.sameSite || cookie.sameSite === WI.Cookie.SameSiteType.None ? "" : WI.Cookie.displayNameForSameSiteType(cookie.sameSite),
I think this reads better as: sameSite: cookie.sameSite && cookie.sameSite !== WI.Cookie.SameSiteType.None ? WI.Cookie.displayNameForSameSiteType(cookie.sameSite) : "",
Daniel Bates
Comment 4
2018-06-20 17:09:12 PDT
Committed
r233027
: <
https://trac.webkit.org/changeset/233027
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug