Bug 186866 – Recalc styles every time defaultAppearance changes

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Timothy Hatcher]

We need to recall style whenever defaultAppearance changes, since AX dark mode is still false in our view.

[Timothy Hatcher]

Created attachment 343188 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/41309805>

[EWS Watchlist]

Comment on attachment 343188 [details]
Patch

Attachment 343188 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/8270908

New failing tests:
accessibility/mac/selection-notification-focus-change.html

[EWS Watchlist]

Created attachment 343196 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[Timothy Hatcher]

Created attachment 343253 [details]
Patch

[Timothy Hatcher]

Test failures seem unrelated. Trying again.

[Megan Gardner]

Comment on attachment 343253 [details]
Patch

unofficial r=me

[Tim Horton]

Comment on attachment 343253 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343253&action=review

> Source/WebCore/ChangeLog:4
> +

weird newline here

[Wenson Hsieh]

Comment on attachment 343253 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343253&action=review

> Source/WebCore/page/Page.cpp:2394
> +    // The system appearance might have changed under us, like for accessability.

Nit - accessibility

> Source/WebKit/UIProcess/WebPageProxy.cpp:7308
> +    // The system appearance might have changed under us, like for accessability.

Nit - accessibility

[Timothy Hatcher]

Created attachment 343342 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 343342 [details]
Patch

Rejecting attachment 343342 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 343342, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/attachment.cgi?id=343342&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=186866&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Processing patch 343342 from bug 186866.
Fetching: https://bugs.webkit.org/attachment.cgi?id=343342
Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 8 diffs from patch file(s).
patching file Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebKit/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebKitLegacy/mac/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/page/Page.cpp
Hunk #2 FAILED at 2388.
1 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/page/Page.cpp.rej
patching file Source/WebCore/page/Page.h
patching file Source/WebKit/UIProcess/WebPageProxy.cpp
patching file Source/WebKit/WebProcess/WebPage/WebPage.cpp
patching file Source/WebKitLegacy/mac/WebView/WebView.mm

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: https://webkit-queues.webkit.org/results/8292935

[Timothy Hatcher]

Created attachment 343345 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 343345 [details]
Patch

Clearing flags on attachment: 343345

Committed r233087: <https://trac.webkit.org/changeset/233087>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Keith Rollin]

Committed r233178: <https://trac.webkit.org/changeset/233178>

[Keith Rollin]

Reverted in r233178. Caused 5% Mac PLT regression. See <rdar://problem/41429742>.