Bug 186862 - [Fullscreen] Use secondary glyph style for fullscreen controls
Summary: [Fullscreen] Use secondary glyph style for fullscreen controls
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-20 14:52 PDT by Jer Noble
Modified: 2018-06-21 11:59 PDT (History)
7 users (show)

See Also:

Attachments
Patch (18.07 KB, patch)
2018-06-20 14:56 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (18.37 KB, patch)
2018-06-20 16:33 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews205 for win-future (12.80 MB, application/zip)
2018-06-21 08:47 PDT, EWS Watchlist 		no flags Details
Patch for landing (18.33 KB, patch)
2018-06-21 11:20 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2018-06-20 14:52:14 PDT 
[Fullscreen] Use secondary glyph style for fullscreen controls
Comment 1 Jer Noble 2018-06-20 14:52:56 PDT 
<rdar://problem/41212210>
Comment 2 Jer Noble 2018-06-20 14:56:11 PDT 
Created attachment 343183 [details]
Patch
Comment 3 Jer Noble 2018-06-20 16:33:53 PDT 
Created attachment 343189 [details]
Patch
Comment 4 Tim Horton 2018-06-20 23:59:29 PDT 
Comment on attachment 343189 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343189&action=review

> Source/WebKit/UIProcess/ios/fullscreen/WKFullscreenStackView.mm:51
> +    CGRect frame = CGRectMake(0, 0, 100, 100);

Where does this 100 come from?

> Source/WebKit/UIProcess/ios/fullscreen/WKFullscreenStackView.mm:59
> +    _backgroundView = [allocAVBackgroundViewInstance() initWithFrame:frame];

Why does this not sit in a RetainPtr?

> Source/WebKit/UIProcess/ios/fullscreen/WKFullscreenStackView.mm:71
> +- (void)addArrangedSubview:(UIView *)subview applyingMaterialStyle:(AVBackgroundViewMaterialStyle)materialStyle tintEffectStyle:(AVBackgroundViewTintEffectStyle)tintEffectStyle

Probably you want a leading underscore here? Or is this an override of a real thing? Seems not to be.
Comment 5 EWS Watchlist 2018-06-21 08:46:53 PDT 
Comment on attachment 343189 [details]
Patch

Attachment 343189 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8277244

New failing tests:
http/tests/preload/onload_event.html
Comment 6 EWS Watchlist 2018-06-21 08:47:04 PDT 
Created attachment 343239 [details]
Archive of layout-test-results from ews205 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews205  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 7 Jer Noble 2018-06-21 11:20:35 PDT 
Created attachment 343252 [details]
Patch for landing
Comment 8 WebKit Commit Bot 2018-06-21 11:59:18 PDT 
Comment on attachment 343252 [details]
Patch for landing

Clearing flags on attachment: 343252

Committed r233052: <https://trac.webkit.org/changeset/233052>
Comment 9 WebKit Commit Bot 2018-06-21 11:59:20 PDT 
All reviewed patches have been landed.  Closing bug.