Bug 186860 - [WebKit on watchOS] Fixed position elements sometimes flicker when scrolling
Summary: [WebKit on watchOS] Fixed position elements sometimes flicker when scrolling
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-20 14:08 PDT by Wenson Hsieh
Modified: 2018-06-20 23:12 PDT (History)
5 users (show)

See Also:

Attachments
Patch (15.00 KB, patch)
2018-06-20 14:42 PDT, Wenson Hsieh 		thorton: review+
Details | Formatted Diff | Diff
Patch for landing (15.03 KB, patch)
2018-06-20 16:18 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2018-06-20 14:08:55 PDT 
<rdar://problem/39953563>
Comment 1 Wenson Hsieh 2018-06-20 14:42:30 PDT 
Created attachment 343182 [details]
Patch
Comment 2 Tim Horton 2018-06-20 16:03:03 PDT 
Comment on attachment 343182 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343182&action=review

> Tools/TestWebKitAPI/Tests/ios/WKScrollViewTests.mm:57
> +    sleep(1);

:( quite a slow API test. but I can't imagine a better way without e.g. overriding internal methods on WKWebView.
Comment 3 Wenson Hsieh 2018-06-20 16:04:24 PDT 
(In reply to Tim Horton from comment #2)
> Comment on attachment 343182 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=343182&action=review
> 
> > Tools/TestWebKitAPI/Tests/ios/WKScrollViewTests.mm:57
> > +    sleep(1);
> 
> :( quite a slow API test. but I can't imagine a better way without e.g.
> overriding internal methods on WKWebView.

True, 1 sec. is somewhat excessive. I'll tone it down.
Comment 4 Wenson Hsieh 2018-06-20 16:18:47 PDT 
Created attachment 343187 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2018-06-20 16:57:28 PDT 
Comment on attachment 343187 [details]
Patch for landing

Clearing flags on attachment: 343187

Committed r233025: <https://trac.webkit.org/changeset/233025>