Bug 18686 - SQUIRRELFISH: implement LabelNode
Summary: SQUIRRELFISH: implement LabelNode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 18624
  Show dependency treegraph
 
Reported: 2008-04-22 15:16 PDT by Cameron Zwarich (cpst)
Modified: 2008-04-22 21:53 PDT (History)
0 users

See Also:


Attachments
Proposed patch (1.47 KB, patch)
2008-04-22 15:18 PDT, Cameron Zwarich (cpst)
no flags Details | Formatted Diff | Diff
Revised proposed patch (8.38 KB, patch)
2008-04-22 16:17 PDT, Cameron Zwarich (cpst)
oliver: review+
Details | Formatted Diff | Diff
Revised proposed patch (8.63 KB, patch)
2008-04-22 16:55 PDT, Cameron Zwarich (cpst)
oliver: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Cameron Zwarich (cpst) 2008-04-22 15:16:58 PDT
LabelNode currently emits code for the enclosing statement but nothing else. This causes a number of JavaScriptCore tests to fail.
Comment 1 Cameron Zwarich (cpst) 2008-04-22 15:18:29 PDT
Created attachment 20758 [details]
Proposed patch

This patch fixes 5 JavaScriptCore tests.
Comment 2 Oliver Hunt 2008-04-22 15:39:04 PDT
Comment on attachment 20758 [details]
Proposed patch

removed review flag as we discussed this allows some incorrect behaviour :(
Comment 3 Cameron Zwarich (cpst) 2008-04-22 16:17:48 PDT
Created attachment 20759 [details]
Revised proposed patch

This patch addresses the issues that Oliver and I discussed on IRC.
Comment 4 Oliver Hunt 2008-04-22 16:50:21 PDT
Comment on attachment 20759 [details]
Revised proposed patch

r=me with a better name than "possibleEmptyBreakTarget"
Comment 5 Cameron Zwarich (cpst) 2008-04-22 16:55:42 PDT
Created attachment 20760 [details]
Revised proposed patch

Here it is, with a better name.