Bug 186859 - Add API for configuring the number of threads used by DFG and FTL
Summary: Add API for configuring the number of threads used by DFG and FTL
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tadeu Zagallo
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-20 12:29 PDT by Tadeu Zagallo
Modified: 2018-06-25 11:30 PDT (History)
8 users (show)

See Also:


Attachments
Patch (12.29 KB, patch)
2018-06-20 15:18 PDT, Tadeu Zagallo
no flags Details | Formatted Diff | Diff
Patch (12.28 KB, patch)
2018-06-25 09:09 PDT, Tadeu Zagallo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tadeu Zagallo 2018-06-20 12:29:01 PDT
The number of threads DFG and FTL use is already configurable via JSC::Options, add an API that also allows changing it at runtime.
Comment 1 Tadeu Zagallo 2018-06-20 12:29:34 PDT
<rdar://problem/41093519>
Comment 2 Tadeu Zagallo 2018-06-20 15:18:48 PDT
Created attachment 343185 [details]
Patch
Comment 3 Build Bot 2018-06-20 15:21:58 PDT
Attachment 343185 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/dfg/DFGWorklist.cpp:501:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Keith Miller 2018-06-20 15:41:29 PDT
Comment on attachment 343185 [details]
Patch

I think we should have a single function that specifies the number of threads our compilers and do our own balancing. The fact that we have two tiers is too low of an implementation detail to expose to our clients, IMO.
Comment 5 Filip Pizlo 2018-06-25 08:42:00 PDT
Comment on attachment 343185 [details]
Patch

I think we should just do this.  We can bikeshed one v. two functions later.
Comment 6 WebKit Commit Bot 2018-06-25 08:59:05 PDT
Comment on attachment 343185 [details]
Patch

Rejecting attachment 343185 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 343185, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as commit-queue@webkit.org...
Fetching: https://bugs.webkit.org/attachment.cgi?id=343185&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=186859&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Processing patch 343185 from bug 186859.
Fetching: https://bugs.webkit.org/attachment.cgi?id=343185
Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Filip Pizlo']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 6 diffs from patch file(s).
patching file Source/JavaScriptCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/JavaScriptCore/API/JSVirtualMachine.mm
patching file Source/JavaScriptCore/API/JSVirtualMachinePrivate.h
patching file Source/JavaScriptCore/API/tests/testapi.mm
patching file Source/JavaScriptCore/dfg/DFGWorklist.cpp
Hunk #1 FAILED at 200.
1 out of 2 hunks FAILED -- saving rejects to file Source/JavaScriptCore/dfg/DFGWorklist.cpp.rej
patching file Source/JavaScriptCore/dfg/DFGWorklist.h

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Filip Pizlo']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: https://webkit-queues.webkit.org/results/8330666
Comment 7 Tadeu Zagallo 2018-06-25 09:09:39 PDT
Created attachment 343502 [details]
Patch

rebase
Comment 8 Build Bot 2018-06-25 09:11:24 PDT
Attachment 343502 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/dfg/DFGWorklist.cpp:501:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 9 WebKit Commit Bot 2018-06-25 11:30:53 PDT
Comment on attachment 343502 [details]
Patch

Clearing flags on attachment: 343502

Committed r233158: <https://trac.webkit.org/changeset/233158>
Comment 10 WebKit Commit Bot 2018-06-25 11:30:55 PDT
All reviewed patches have been landed.  Closing bug.