Bug 186859 – Add API for configuring the number of threads used by DFG and FTL

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Tadeu Zagallo]

The number of threads DFG and FTL use is already configurable via JSC::Options, add an API that also allows changing it at runtime.

[Tadeu Zagallo]

<rdar://problem/41093519>

[Tadeu Zagallo]

Created attachment 343185 [details]
Patch

[EWS Watchlist]

Attachment 343185 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/dfg/DFGWorklist.cpp:501:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Keith Miller]

Comment on attachment 343185 [details]
Patch

I think we should have a single function that specifies the number of threads our compilers and do our own balancing. The fact that we have two tiers is too low of an implementation detail to expose to our clients, IMO.

[Filip Pizlo]

Comment on attachment 343185 [details]
Patch

I think we should just do this.  We can bikeshed one v. two functions later.

[WebKit Commit Bot]

Comment on attachment 343185 [details]
Patch

Rejecting attachment 343185 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 343185, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/attachment.cgi?id=343185&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=186859&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Processing patch 343185 from bug 186859.
Fetching: https://bugs.webkit.org/attachment.cgi?id=343185
Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Filip Pizlo']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 6 diffs from patch file(s).
patching file Source/JavaScriptCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/JavaScriptCore/API/JSVirtualMachine.mm
patching file Source/JavaScriptCore/API/JSVirtualMachinePrivate.h
patching file Source/JavaScriptCore/API/tests/testapi.mm
patching file Source/JavaScriptCore/dfg/DFGWorklist.cpp
Hunk #1 FAILED at 200.
1 out of 2 hunks FAILED -- saving rejects to file Source/JavaScriptCore/dfg/DFGWorklist.cpp.rej
patching file Source/JavaScriptCore/dfg/DFGWorklist.h

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Filip Pizlo']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: https://webkit-queues.webkit.org/results/8330666

[Tadeu Zagallo]

Created attachment 343502 [details]
Patch

rebase

[EWS Watchlist]

Attachment 343502 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/dfg/DFGWorklist.cpp:501:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 343502 [details]
Patch

Clearing flags on attachment: 343502

Committed r233158: <https://trac.webkit.org/changeset/233158>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.