Bug 186828 - flattenDictionaryStructure needs to zero properties that have been compressed away
Summary: flattenDictionaryStructure needs to zero properties that have been compressed...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-19 17:10 PDT by Keith Miller
Modified: 2018-06-19 18:29 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.76 KB, patch)
2018-06-19 17:11 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
Patch for landing (2.25 KB, patch)
2018-06-19 18:21 PDT, Keith Miller 		keith_miller: commit-queue+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2018-06-19 17:10:42 PDT 
flattenDictionaryStructure needs to zero properties that have been compressed away
Comment 1 Keith Miller 2018-06-19 17:11:16 PDT 
Created attachment 343122 [details]
Patch
Comment 2 Mark Lam 2018-06-19 17:21:47 PDT 
Comment on attachment 343122 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343122&action=review

r=me

> Source/JavaScriptCore/runtime/Structure.cpp:783
> +        // We need to make sure we zero our unused butterfly space otherwise the GC might see a stale pointer.

I think you can drop the "make sure we" part, and I suggest adding a semicolon after "space" and a comma after "otherwise".
Comment 3 Keith Miller 2018-06-19 18:21:03 PDT 
Created attachment 343128 [details]
Patch for landing
Comment 4 Keith Miller 2018-06-19 18:28:09 PDT 
Committed r233001: <https://trac.webkit.org/changeset/233001>
Comment 5 Radar WebKit Bug Importer 2018-06-19 18:29:18 PDT 
<rdar://problem/41272865>