Bug 186826 - [Fullscreen] Exit fullscreen when opening a new tab
Summary: [Fullscreen] Exit fullscreen when opening a new tab
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-19 16:38 PDT by Jer Noble
Modified: 2018-06-22 13:25 PDT (History)
7 users (show)

See Also:

Attachments
Patch (3.83 KB, patch)
2018-06-19 16:41 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews104 for mac-sierra-wk2 (2.99 MB, application/zip)
2018-06-19 20:31 PDT, EWS Watchlist 		no flags Details
Archive of layout-test-results from ews204 for win-future (12.76 MB, application/zip)
2018-06-20 18:11 PDT, EWS Watchlist 		no flags Details
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2018-06-19 16:38:56 PDT 
[Fullscreen] Exit fullscreen when opening a new tab
Comment 1 Jer Noble 2018-06-19 16:39:18 PDT 
<rdar://problem/40853211>
Comment 2 Jer Noble 2018-06-19 16:41:47 PDT 
Created attachment 343120 [details]
Patch
Comment 3 EWS Watchlist 2018-06-19 20:31:04 PDT 
Comment on attachment 343120 [details]
Patch

Attachment 343120 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/8259914

New failing tests:
accessibility/mac/selection-notification-focus-change.html
Comment 4 EWS Watchlist 2018-06-19 20:31:06 PDT 
Created attachment 343130 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 5 EWS Watchlist 2018-06-20 18:11:42 PDT 
Comment on attachment 343120 [details]
Patch

Attachment 343120 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8271037

New failing tests:
http/tests/security/video-poster-cross-origin-crash2.html
Comment 6 EWS Watchlist 2018-06-20 18:11:53 PDT 
Created attachment 343198 [details]
Archive of layout-test-results from ews204 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews204  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 7 Brent Fulgham 2018-06-22 12:53:33 PDT 
Comment on attachment 343120 [details]
Patch

r=me. The test flakiness seems unrelated to this change.
Comment 8 WebKit Commit Bot 2018-06-22 13:25:02 PDT 
Comment on attachment 343120 [details]
Patch

Clearing flags on attachment: 343120

Committed r233095: <https://trac.webkit.org/changeset/233095>
Comment 9 WebKit Commit Bot 2018-06-22 13:25:03 PDT 
All reviewed patches have been landed.  Closing bug.