Bug 186819 – Corner of two scroll bars is white with dark mode enabled

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Timothy Hatcher]

The corner is always white.

<rdar://problem/40434350>

[Timothy Hatcher]

Created attachment 343098 [details]
Patch

[Timothy Hatcher]

Created attachment 343104 [details]
Patch

[Timothy Hatcher]

Created attachment 343105 [details]
Patch

[Timothy Hatcher]

Created attachment 343112 [details]
Patch

[Timothy Hatcher]

Created attachment 343172 [details]
Patch

[EWS Watchlist]

Comment on attachment 343172 [details]
Patch

Attachment 343172 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/8268245

New failing tests:
http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm

[EWS Watchlist]

Created attachment 343177 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[Timothy Hatcher]

Created attachment 343184 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 343184 [details]
Patch

Is there a way to do this that doesn't plumb those two bools through, which pollutes a lot of function signatures?

[Timothy Hatcher]

Created attachment 343336 [details]
Patch

[Timothy Hatcher]

(In reply to Simon Fraser (smfr) from comment #9)
> Comment on attachment 343184 [details]
> Patch
> 
> Is there a way to do this that doesn't plumb those two bools through, which
> pollutes a lot of function signatures?

I agree. It is a mess as-is.

One way would be to add LocalDefaultSystemAppearance at the top levels anywhere we draw. I'll see if that would be an option.

[Timothy Hatcher]

Created attachment 343387 [details]
Patch

[Tim Horton]

Comment on attachment 343387 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343387&action=review

> Source/WebKit/UIProcess/mac/WKPrintingView.mm:571
> +#if PLATFORM(MAC)

This whole file is PLATFORM(MAC)

[Timothy Hatcher]

Created attachment 343393 [details]
Patch

[Timothy Hatcher]

Created attachment 343394 [details]
Patch

[Tim Horton]

Comment on attachment 343394 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343394&action=review

The PLATFORM(MAC)s everywhere are so sad.

> Source/WebCore/PAL/pal/spi/mac/NSAppearanceSPI.h:2
> + * Copyright (C) 2015 Apple Inc.  All rights reserved.

2018

> Source/WebCore/platform/mac/ScrollbarThemeMac.mm:574
> +    auto cornerDrawingOptions = adoptCF(CFDictionaryCreateMutable(kCFAllocatorDefault, 0, &kCFTypeDictionaryKeyCallBacks, &kCFTypeDictionaryValueCallBacks));
> +
> +    CFDictionarySetValue(cornerDrawingOptions.get(), kCUIWidgetKey, kCUIWidgetScrollBarTrackCorner);
> +    CFDictionarySetValue(cornerDrawingOptions.get(), kCUIIsFlippedKey, kCFBooleanTrue);

Why not just a ObjC dictionary literal?

[Timothy Hatcher]

Created attachment 343404 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 343404 [details]
Patch

Clearing flags on attachment: 343404

Committed r233116: <https://trac.webkit.org/changeset/233116>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.