Bug 186817 - EWS: Support fetching latest status for security-sensitive bugs
Summary: EWS: Support fetching latest status for security-sensitive bugs
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 186832
  Show dependency treegraph
 
Reported: 2018-06-19 13:56 PDT by Daniel Bates
Modified: 2018-06-22 16:05 PDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2018-06-19 13:56:09 PDT
Following the patch for bug #186291, the feeder queue and webkit-patch will now upload every patch that is attached to a security-sensitive bug and its metadata (e.g. whether the patch is marked r?) to <https://webkit-queues.webkit.org> so that the EWS machines can access it. Currently the EWS machinery in webkitpy fetches the metadata for the patch (via a call to AbstractEarlyWarningSystem.refetch_patch() [1]) before it begins building and testing to check if the patch should still be processed (e.g. is it still marked r?). For patch on non-security sensitive bugs this machinery can access Bugzilla and fetch the latest state. For patches on security-sensitive bugs the EWS bot cannot fetch the latest state from Bugzilla (since it does not have access to view the bug) and hence fetches the state from <https://webkit-queues.webkit.org>. But <https://webkit-queues.webkit.org> only reflects the state of the patch when it was uploaded. We need to find a way to allow the EWS machinery to fetch the latest state of such patches.

[1] <https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py?rev=232979#L153>
Comment 1 Daniel Bates 2018-06-22 15:50:28 PDT
We likely should revert the patch for bug #186923 as part of the fix for this bug.