EWS: Support fetching latest status for security-sensitive bugs 
https://bugs.webkit.org/show_bug.cgi?id=186817
Summary EWS: Support fetching latest status for security-sensitive bugs
Daniel Bates
Reported 2018-06-19 13:56:09 PDT
Following the patch for bug #186291, the feeder queue and webkit-patch will now upload every patch that is attached to a security-sensitive bug and its metadata (e.g. whether the patch is marked r?) to <https://webkit-queues.webkit.org> so that the EWS machines can access it. Currently the EWS machinery in webkitpy fetches the metadata for the patch (via a call to AbstractEarlyWarningSystem.refetch_patch() [1]) before it begins building and testing to check if the patch should still be processed (e.g. is it still marked r?). For patch on non-security sensitive bugs this machinery can access Bugzilla and fetch the latest state. For patches on security-sensitive bugs the EWS bot cannot fetch the latest state from Bugzilla (since it does not have access to view the bug) and hence fetches the state from <https://webkit-queues.webkit.org>. But <https://webkit-queues.webkit.org> only reflects the state of the patch when it was uploaded. We need to find a way to allow the EWS machinery to fetch the latest state of such patches. [1] <https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py?rev=232979#L153>
Attachments
Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2018-06-22 15:50:28 PDT
We likely should revert the patch for bug #186923 as part of the fix for this bug.
Note You need to log in before you can comment on or make changes to this bug.