Bug 186816 – Crash running check-webkit-style on webrtc/.../exceptions.py

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Keith Rollin]

Running check-webkit-style on all of Source results in the following crash on Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/exceptions.py:

Traceback (most recent call last):
  File "/Volumes/Data/dev/webkit/OpenSource/Tools/Scripts/check-webkit-style", line 48, in <module>
    sys.exit(CheckWebKitStyle().main())
  File "/Volumes/Data/dev/webkit/OpenSource/Tools/Scripts/webkitpy/style/main.py", line 149, in main
    file_reader.process_paths(paths)
  File "/Volumes/Data/dev/webkit/OpenSource/Tools/Scripts/webkitpy/style/filereader.py", line 147, in process_paths
    self._process_directory(directory=path)
  File "/Volumes/Data/dev/webkit/OpenSource/Tools/Scripts/webkitpy/style/filereader.py", line 142, in _process_directory
    self.process_file(file_path)
  File "/Volumes/Data/dev/webkit/OpenSource/Tools/Scripts/webkitpy/style/filereader.py", line 137, in process_file
    self._processor.process(lines, file_path, **kwargs)
  File "/Volumes/Data/dev/webkit/OpenSource/Tools/Scripts/webkitpy/style/checker.py", line 970, in process
    checker.check(lines)
  File "/Volumes/Data/dev/webkit/OpenSource/Tools/Scripts/webkitpy/style/checkers/python.py", line 43, in check
    self._check_pylint(lines)
  File "/Volumes/Data/dev/webkit/OpenSource/Tools/Scripts/webkitpy/style/checkers/python.py", line 71, in _check_pylint
    output = pylinter.run(['-E', self._file_path])
  File "/Volumes/Data/dev/webkit/OpenSource/Tools/Scripts/webkitpy/style/checkers/python.py", line 106, in run
    lint.Run(['--rcfile', self._pylintrc] + argv, reporter=ParseableTextReporter(output=output), exit=False)
  File "/Volumes/Data/dev/webkit/OpenSource/Tools/Scripts/webkitpy/thirdparty/autoinstalled/pylint/lint.py", line 879, in __init__
    linter.check(args)
  File "/Volumes/Data/dev/webkit/OpenSource/Tools/Scripts/webkitpy/thirdparty/autoinstalled/pylint/lint.py", line 502, in check
    self.check_astng_module(astng, walker, rawcheckers)
  File "/Volumes/Data/dev/webkit/OpenSource/Tools/Scripts/webkitpy/thirdparty/autoinstalled/pylint/lint.py", line 574, in check_astng_module
    walker.walk(astng)
  File "/Volumes/Data/dev/webkit/OpenSource/Tools/Scripts/webkitpy/thirdparty/autoinstalled/pylint/utils.py", line 528, in walk
    self.walk(child)
  File "/Volumes/Data/dev/webkit/OpenSource/Tools/Scripts/webkitpy/thirdparty/autoinstalled/pylint/utils.py", line 528, in walk
    self.walk(child)
  File "/Volumes/Data/dev/webkit/OpenSource/Tools/Scripts/webkitpy/thirdparty/autoinstalled/pylint/utils.py", line 525, in walk
    cb(astng)
  File "/Volumes/Data/dev/webkit/OpenSource/Tools/Scripts/webkitpy/thirdparty/autoinstalled/pylint/checkers/variables.py", line 387, in visit_name
    assert not stmt.root().file.endswith('.py')
AttributeError: 'NoneType' object has no attribute 'endswith'

[Radar WebKit Bug Importer]

<rdar://problem/41262553>

[Keith Rollin]

It's not apparent to me why the crash is occurring. Trying to write a unittest that checks this file in isolation does not reproduce the crash. But the crash goes away when updating to pylint-0.25.2.

(Note that 0.25.2 is still seven years out-of-date, but I'm not sure if I want to try updating to 1.9.2 or 2.0-dev.)

[Keith Rollin]

Created attachment 343095 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 343095 [details]
Patch

Clearing flags on attachment: 343095

Committed r232987: <https://trac.webkit.org/changeset/232987>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.