Bug 186813 - Use getCurrentProcessID over getpid
Summary: Use getCurrentProcessID over getpid
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-19 12:23 PDT by Don Olmstead
Modified: 2018-06-19 15:03 PDT (History)
9 users (show)

See Also:

Attachments
Patch (6.71 KB, patch)
2018-06-19 12:33 PDT, Don Olmstead 		no flags Details | Formatted Diff | Diff
Patch (6.73 KB, patch)
2018-06-19 12:37 PDT, Don Olmstead 		no flags Details | Formatted Diff | Diff
Patch (3.94 KB, patch)
2018-06-19 13:47 PDT, Don Olmstead 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2018-06-19 12:23:50 PDT 
getpid is used in common code instead of getCurrentProcessID.
Comment 1 Don Olmstead 2018-06-19 12:33:34 PDT 
Created attachment 343079 [details]
Patch
Comment 2 EWS Watchlist 2018-06-19 12:35:49 PDT 
Attachment 343079 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Don Olmstead 2018-06-19 12:37:22 PDT 
Created attachment 343080 [details]
Patch
Comment 4 Chris Dumez 2018-06-19 12:53:52 PDT 
While I see the value in cross platform code, I am not convinced we should update platform-specific code.
Comment 5 Don Olmstead 2018-06-19 13:23:57 PDT 
(In reply to Chris Dumez from comment #4)
> While I see the value in cross platform code, I am not convinced we should
> update platform-specific code.

I don't have a strong opinion on that. I'm fine with removing references in the platform specific bits. Seemed like if it was there in WTF we should just use it.
Comment 6 Don Olmstead 2018-06-19 13:47:25 PDT 
Created attachment 343092 [details]
Patch

Modified to just touch common code.
Comment 7 WebKit Commit Bot 2018-06-19 15:02:40 PDT 
Comment on attachment 343092 [details]
Patch

Clearing flags on attachment: 343092

Committed r232988: <https://trac.webkit.org/changeset/232988>
Comment 8 WebKit Commit Bot 2018-06-19 15:02:42 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2018-06-19 15:03:25 PDT 
<rdar://problem/41265747>