Bug 186780 - Reset the test expectations for failing successes_RSA-PSS web-platform-tests
Summary: Reset the test expectations for failing successes_RSA-PSS web-platform-tests
Status: RESOLVED DUPLICATE of bug 186863
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-06-18 11:35 PDT by Brendan McLoughlin
Modified: 2019-03-20 17:40 PDT (History)
7 users (show)

See Also:


Attachments
Patch (30.50 KB, patch)
2018-06-18 11:36 PDT, Brendan McLoughlin
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews100 for mac-sierra (2.61 MB, application/zip)
2018-06-18 12:32 PDT, EWS Watchlist
no flags Details
Archive of layout-test-results from ews117 for mac-sierra (3.15 MB, application/zip)
2018-06-18 13:04 PDT, EWS Watchlist
no flags Details
Patch (51.10 KB, patch)
2018-06-18 13:12 PDT, Brendan McLoughlin
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews206 for win-future (12.28 MB, application/zip)
2018-06-18 15:34 PDT, EWS Watchlist
no flags Details
Patch (51.07 KB, patch)
2018-06-19 04:39 PDT, Brendan McLoughlin
youennf: review+
Details | Formatted Diff | Diff
Archive of layout-test-results from ews121 for ios-simulator-wk2 (2.24 MB, application/zip)
2018-06-19 06:22 PDT, EWS Watchlist
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Brendan McLoughlin 2018-06-18 11:35:48 PDT
Reset the test expectations for failing successes_RSA-PSS web-platform-tests
Comment 1 Brendan McLoughlin 2018-06-18 11:36:11 PDT
Created attachment 342955 [details]
Patch
Comment 2 EWS Watchlist 2018-06-18 12:32:49 PDT
Comment on attachment 342955 [details]
Patch

Attachment 342955 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/8234746

New failing tests:
imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/successes_RSA-PSS.https.any.html
imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/successes_RSA-PSS.https.any.worker.html
Comment 3 EWS Watchlist 2018-06-18 12:32:50 PDT
Created attachment 342963 [details]
Archive of layout-test-results from ews100 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 4 EWS Watchlist 2018-06-18 13:04:05 PDT
Comment on attachment 342955 [details]
Patch

Attachment 342955 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/8234773

New failing tests:
imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/successes_RSA-PSS.https.any.html
imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/successes_RSA-PSS.https.any.worker.html
Comment 5 EWS Watchlist 2018-06-18 13:04:07 PDT
Created attachment 342964 [details]
Archive of layout-test-results from ews117 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 6 Brendan McLoughlin 2018-06-18 13:12:15 PDT
Created attachment 342966 [details]
Patch
Comment 7 EWS Watchlist 2018-06-18 15:34:46 PDT
Comment on attachment 342966 [details]
Patch

Attachment 342966 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/8236687

New failing tests:
http/tests/security/canvas-remote-read-remote-video-blocked-no-crossorigin.html
Comment 8 EWS Watchlist 2018-06-18 15:34:58 PDT
Created attachment 342979 [details]
Archive of layout-test-results from ews206 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 9 Brendan McLoughlin 2018-06-19 04:39:27 PDT
Created attachment 343047 [details]
Patch
Comment 10 youenn fablet 2018-06-19 05:34:14 PDT
Comment on attachment 343047 [details]
Patch

Patch looks fine to me.
David, can you verify that this is fine with you too before committing it?
Comment 11 EWS Watchlist 2018-06-19 06:22:52 PDT
Comment on attachment 343047 [details]
Patch

Attachment 343047 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/8246460

New failing tests:
imported/w3c/web-platform-tests/FileAPI/blob/Blob-constructor.html
Comment 12 EWS Watchlist 2018-06-19 06:22:53 PDT
Created attachment 343050 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.4
Comment 13 youenn fablet 2018-06-19 07:05:38 PDT
Comment on attachment 343047 [details]
Patch

iOS sim error is probably unrelated
Comment 14 Dawei Fenton (:realdawei) 2018-06-20 15:22:45 PDT
(In reply to youenn fablet from comment #10)
> Comment on attachment 343047 [details]
> Patch
> 
> Patch looks fine to me.
> David, can you verify that this is fine with you too before committing it?

actually this patch would not have fixed the issue, I went ahead and landed the fix here: https://trac.webkit.org/r233023
Comment 15 Dawei Fenton (:realdawei) 2018-06-20 15:35:50 PDT
(In reply to David Fenton from comment #14)
> (In reply to youenn fablet from comment #10)
> > Comment on attachment 343047 [details]
> > Patch
> > 
> > Patch looks fine to me.
> > David, can you verify that this is fine with you too before committing it?
> 
> actually this patch would not have fixed the issue, I went ahead and landed
> the fix here: https://trac.webkit.org/r233023

The issue was that the tests need to be "expected to pass" on High Sierra, but continue to be "expected to fail" on Sierra.  

So I rebaselined High Sierra by copying from it's actual results and adding these to  platform/mac, and then copied expected results from imported/w3c/web-platform-tests..to platform/mac-sierra
Comment 16 Ryan Haddad 2018-06-20 15:36:31 PDT

*** This bug has been marked as a duplicate of bug 186863 ***