Bug 186770 – Expose RTCPeerConnectionIceEventInit constructor

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[youenn fablet]

Expose RTCPeerConnectionIceEventInit constructor as per spec

[youenn fablet]

Created attachment 342944 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/41212281>

[Alex Christensen]

Comment on attachment 342944 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342944&action=review

> Source/WebCore/Modules/mediastream/RTCPeerConnectionIceEvent.idl:28
> +    DOMString? url;

Why is this not a DOMURL?

[youenn fablet]

> > Source/WebCore/Modules/mediastream/RTCPeerConnectionIceEvent.idl:28
> > +    DOMString? url;
> 
> Why is this not a DOMURL?

I am not quite sure, it is defined in RFCs as specific URIs and I believe it could be passed as DOMURL.
But this would require changing an API that is there since quite some time with only small benefits.
Not this particular attribute but RTCIceServer which has a "DOMString url" attribute and is passed as parameter of RTCPeerConnection getter.

[youenn fablet]

Created attachment 342965 [details]
Patch for landing

[youenn fablet]

(In reply to youenn fablet from comment #5)
> Created attachment 342965 [details]
> Patch for landing

Updated PeerConnectionBackend::finishedRegisteringMDNSName implementation to use more WTFMove.

[WebKit Commit Bot]

Comment on attachment 342965 [details]
Patch for landing

Clearing flags on attachment: 342965

Committed r232943: <https://trac.webkit.org/changeset/232943>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.