Bug 186770 - Expose RTCPeerConnectionIceEventInit constructor
Summary: Expose RTCPeerConnectionIceEventInit constructor
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-18 09:05 PDT by youenn fablet
Modified: 2018-06-18 13:48 PDT (History)
6 users (show)

See Also:

Attachments
Patch (29.01 KB, patch)
2018-06-18 09:13 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (28.93 KB, patch)
2018-06-18 13:08 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2018-06-18 09:05:04 PDT 
Expose RTCPeerConnectionIceEventInit constructor as per spec
Comment 1 youenn fablet 2018-06-18 09:13:25 PDT 
Created attachment 342944 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2018-06-18 09:13:53 PDT 
<rdar://problem/41212281>
Comment 3 Alex Christensen 2018-06-18 10:27:46 PDT 
Comment on attachment 342944 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342944&action=review

> Source/WebCore/Modules/mediastream/RTCPeerConnectionIceEvent.idl:28
> +    DOMString? url;

Why is this not a DOMURL?
Comment 4 youenn fablet 2018-06-18 13:06:24 PDT 
> > Source/WebCore/Modules/mediastream/RTCPeerConnectionIceEvent.idl:28
> > +    DOMString? url;
> 
> Why is this not a DOMURL?

I am not quite sure, it is defined in RFCs as specific URIs and I believe it could be passed as DOMURL.
But this would require changing an API that is there since quite some time with only small benefits.
Not this particular attribute but RTCIceServer which has a "DOMString url" attribute and is passed as parameter of RTCPeerConnection getter.
Comment 5 youenn fablet 2018-06-18 13:08:51 PDT 
Created attachment 342965 [details]
Patch for landing
Comment 6 youenn fablet 2018-06-18 13:10:01 PDT 
(In reply to youenn fablet from comment #5)
> Created attachment 342965 [details]
> Patch for landing

Updated PeerConnectionBackend::finishedRegisteringMDNSName implementation to use more WTFMove.
Comment 7 WebKit Commit Bot 2018-06-18 13:48:14 PDT 
Comment on attachment 342965 [details]
Patch for landing

Clearing flags on attachment: 342965

Committed r232943: <https://trac.webkit.org/changeset/232943>
Comment 8 WebKit Commit Bot 2018-06-18 13:48:16 PDT 
All reviewed patches have been landed.  Closing bug.