WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
186761
Fix remaining Cross-Origin-Resource-Policy failures, if any
https://bugs.webkit.org/show_bug.cgi?id=186761
Summary
Fix remaining Cross-Origin-Resource-Policy failures, if any
Anne van Kesteren
Reported
2018-06-18 06:33:21 PDT
I'm not quite sure what release this feature is in, but I wrote tests and got them landed in web-platform-tests at fetch/cross-origin-resource-policy and I suspect there may be a failure, especially given that we decided on the HTTPS restriction quite late.
Attachments
Patch
(22.97 KB, patch)
2018-07-06 19:02 PDT
,
youenn fablet
ews-watchlist
: commit-queue-
Details
Formatted Diff
Diff
Archive of layout-test-results from ews126 for ios-simulator-wk2
(2.33 MB, application/zip)
2018-07-09 17:28 PDT
,
EWS Watchlist
no flags
Details
Archive of layout-test-results from ews102 for mac-sierra
(2.71 MB, application/zip)
2018-07-09 18:22 PDT
,
EWS Watchlist
no flags
Details
Patch
(53.85 KB, patch)
2018-07-09 21:08 PDT
,
youenn fablet
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
youenn fablet
Comment 1
2018-06-18 06:43:41 PDT
(In reply to Anne van Kesteren from
comment #0
)
> I'm not quite sure what release this feature is in, but I wrote tests and > got them landed in web-platform-tests at fetch/cross-origin-resource-policy > and I suspect there may be a failure, especially given that we decided on > the HTTPS restriction quite late.
Great to hear web-platform-tests tests are landed, I was waiting for them to update the implementation and remove our redundant tests.
Radar WebKit Bug Importer
Comment 2
2018-06-18 06:44:04 PDT
<
rdar://problem/41209829
>
youenn fablet
Comment 3
2018-06-18 14:16:07 PDT
Only WPT failure seems to be related to case-insensitive comparison of the value. WebKit currently allows SAME-ORIGIN. It does not seem that we have yet added tests for HTTP same origin loads from HTTPS contexts.
Anne van Kesteren
Comment 4
2018-06-19 00:06:24 PDT
If you mean same site, that would be fetch/cross-origin-resource-policy/scheme-restriction.https.window.js For origin HTTP/HTTPS does not matter as the scheme has to be identical.
youenn fablet
Comment 5
2018-07-06 19:02:49 PDT
Created
attachment 344499
[details]
Patch
EWS Watchlist
Comment 6
2018-07-09 17:28:44 PDT
Comment on
attachment 344499
[details]
Patch
Attachment 344499
[details]
did not pass ios-sim-ews (ios-simulator-wk2): Output:
https://webkit-queues.webkit.org/results/8487321
New failing tests: http/wpt/cross-origin-resource-policy/fetch.html
EWS Watchlist
Comment 7
2018-07-09 17:28:45 PDT
Created
attachment 344645
[details]
Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4
EWS Watchlist
Comment 8
2018-07-09 18:22:45 PDT
Comment on
attachment 344499
[details]
Patch
Attachment 344499
[details]
did not pass mac-ews (mac): Output:
https://webkit-queues.webkit.org/results/8488465
New failing tests: media/media-fullscreen-return-to-inline.html
EWS Watchlist
Comment 9
2018-07-09 18:22:47 PDT
Created
attachment 344650
[details]
Archive of layout-test-results from ews102 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-sierra Platform: Mac OS X 10.12.6
youenn fablet
Comment 10
2018-07-09 21:08:35 PDT
Created
attachment 344662
[details]
Patch
WebKit Commit Bot
Comment 11
2018-07-11 12:36:23 PDT
Comment on
attachment 344662
[details]
Patch Clearing flags on attachment: 344662 Committed
r233739
: <
https://trac.webkit.org/changeset/233739
>
WebKit Commit Bot
Comment 12
2018-07-11 12:36:25 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug