Bug 186756 – [GTK] Wrong variable used in RenderThemeGtk

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Tomas Popela]

Found by Coverity scan:

1. webkitgtk-2.20.3/Source/WebCore/rendering/RenderThemeGtk.cpp:1304: cond_const: Condition "part != WebCore::SliderThumbHorizontalPart", taking false branch. Now the value of "part" is equal to 44.
2. webkitgtk-2.20.3/Source/WebCore/rendering/RenderThemeGtk.cpp:1304: cond_const: Condition "part != WebCore::SliderThumbVerticalPart", taking false branch. Now the value of "part" is equal to 45.
3. webkitgtk-2.20.3/Source/WebCore/rendering/RenderThemeGtk.cpp:1307: between: At condition "part == WebCore::SliderHorizontalPart", the value of "part" must be between 44 and 45.
4. webkitgtk-2.20.3/Source/WebCore/rendering/RenderThemeGtk.cpp:1307: dead_error_condition: The condition "part == WebCore::SliderHorizontalPart" cannot be true.
5. webkitgtk-2.20.3/Source/WebCore/rendering/RenderThemeGtk.cpp:1307: dead_error_line: Execution cannot reach the expression "WebCore::RenderThemeWidget::Type::HorizontalSlider" inside this statement: "sliderWidget = static_cast<...".
#  1305|           return;
#  1306|   
#  1307|->     auto& sliderWidget = static_cast<RenderThemeSlider&>(RenderThemeWidget::getOrCreate(part == SliderHorizontalPart ? RenderThemeWidget::Type::HorizontalSlider : RenderThemeWidget::Type::VerticalSlider));
#  1308|       sliderWidget.scale().setState(GTK_STATE_FLAG_NORMAL);
#  1309|       sliderWidget.trough().setState(GTK_STATE_FLAG_NORMAL);

[Tomas Popela]

Created attachment 342922 [details]
Patch

[Carlos Garcia Campos]

Comment on attachment 342922 [details]
Patch

Good catch!

[Michael Catanzaro]

Comment on attachment 342922 [details]
Patch

Clearing flags on attachment: 342922

Committed r232928: <https://trac.webkit.org/changeset/232928>

[Michael Catanzaro]

All reviewed patches have been landed.  Closing bug.