Bug 186736 - JITThunks wastes 106KB of HashTable capacity on cnn.com
Summary: JITThunks wastes 106KB of HashTable capacity on cnn.com
Status: RESOLVED DUPLICATE of bug 207715
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-16 12:31 PDT by Simon Fraser (smfr)
Modified: 2022-02-12 19:52 PST (History)
6 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2018-06-16 12:31:57 PDT 
Using tooling from bug 186698, loading can and running "notifyutil -p com.apple.WebKit.dumpHashTableCapacity" shows:

Wasted capacity: 106528 bytes (used 24544 of 131072 bytes, utilization: 18.73%) - 1 allocations
1   0x11623be95 WTF::HashTable<std::__1::tuple<JSC::TaggedNativeFunction, JSC::TaggedNativeFunction, WTF::String>, WTF::KeyValuePair<std::__1::tuple<JSC::TaggedNativeFunction, JSC::TaggedNativeFunction, WTF::String>, JSC::Weak<JSC::NativeExecutable> >, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<std::__1::tuple<JSC::TaggedNativeFunction, JSC::TaggedNativeFunction, WTF::String>, JSC::Weak<JSC::NativeExecutable> > >, JSC::JITThunks::HostFunctionHash, WTF::HashMap<std::__1::tuple<JSC::TaggedNativeFunction, JSC::TaggedNativeFunction, WTF::String>, JSC::Weak<JSC::NativeExecutable>, JSC::JITThunks::HostFunctionHash, JSC::JITThunks::HostFunctionHashTrait, WTF::HashTraits<JSC::Weak<JSC::NativeExecutable> > >::KeyValuePairTraits, JSC::JITThunks::HostFunctionHashTrait>::HashTable()
2   0x11623be75 WTF::HashMap<std::__1::tuple<JSC::TaggedNativeFunction, JSC::TaggedNativeFunction, WTF::String>, JSC::Weak<JSC::NativeExecutable>, JSC::JITThunks::HostFunctionHash, JSC::JITThunks::HostFunctionHashTrait, WTF::HashTraits<JSC::Weak<JSC::NativeExecutable> > >::HashMap()
3   0x11623be55 WTF::HashMap<std::__1::tuple<JSC::TaggedNativeFunction, JSC::TaggedNativeFunction, WTF::String>, JSC::Weak<JSC::NativeExecutable>, JSC::JITThunks::HostFunctionHash, JSC::JITThunks::HostFunctionHashTrait, WTF::HashTraits<JSC::Weak<JSC::NativeExecutable> > >::HashMap()
4   0x116233661 JSC::JITThunks::JITThunks()
5   0x116233725 JSC::JITThunks::JITThunks()
6   0x1166be558 JSC::VM::VM(JSC::VM::VMType, JSC::HeapType)
7   0x1166c1d51 JSC::VM::VM(JSC::VM::VMType, JSC::HeapType)
8   0x1166c5406 JSC::VM::create(JSC::HeapType)
Comment 1 Radar WebKit Bug Importer 2018-06-16 12:32:19 PDT 
<rdar://problem/41189174>
Comment 2 Simon Fraser (smfr) 2018-06-16 12:44:19 PDT 
On nytimes.com:

Wasted capacity: 98176 bytes (used 32896 of 131072 bytes, utilization: 25.10%) - 1 allocations
1   0x11623be95 WTF::HashTable<std::__1::tuple<JSC::TaggedNativeFunction, JSC::TaggedNativeFunction, WTF::String>, WTF::KeyValuePair<std::__1::tuple<JSC::TaggedNativeFunction, JSC::TaggedNativeFunction, WTF::String>, JSC::Weak<JSC::NativeExecutable> >, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<std::__1::tuple<JSC::TaggedNativeFunction, JSC::TaggedNativeFunction, WTF::String>, JSC::Weak<JSC::NativeExecutable> > >, JSC::JITThunks::HostFunctionHash, WTF::HashMap<std::__1::tuple<JSC::TaggedNativeFunction, JSC::TaggedNativeFunction, WTF::String>, JSC::Weak<JSC::NativeExecutable>, JSC::JITThunks::HostFunctionHash, JSC::JITThunks::HostFunctionHashTrait, WTF::HashTraits<JSC::Weak<JSC::NativeExecutable> > >::KeyValuePairTraits, JSC::JITThunks::HostFunctionHashTrait>::HashTable()
2   0x11623be75 WTF::HashMap<std::__1::tuple<JSC::TaggedNativeFunction, JSC::TaggedNativeFunction, WTF::String>, JSC::Weak<JSC::NativeExecutable>, JSC::JITThunks::HostFunctionHash, JSC::JITThunks::HostFunctionHashTrait, WTF::HashTraits<JSC::Weak<JSC::NativeExecutable> > >::HashMap()
3   0x11623be55 WTF::HashMap<std::__1::tuple<JSC::TaggedNativeFunction, JSC::TaggedNativeFunction, WTF::String>, JSC::Weak<JSC::NativeExecutable>, JSC::JITThunks::HostFunctionHash, JSC::JITThunks::HostFunctionHashTrait, WTF::HashTraits<JSC::Weak<JSC::NativeExecutable> > >::HashMap()
4   0x116233661 JSC::JITThunks::JITThunks()
5   0x116233725 JSC::JITThunks::JITThunks()
6   0x1166be558 JSC::VM::VM(JSC::VM::VMType, JSC::HeapType)
7   0x1166c1d51 JSC::VM::VM(JSC::VM::VMType, JSC::HeapType)
8   0x1166c5406 JSC::VM::create(JSC::HeapType)
Comment 3 Yusuke Suzuki 2020-02-29 01:19:38 PST 
Note that we recently compacted this into 1/4 size.
Comment 4 Yusuke Suzuki 2020-02-29 01:19:54 PST 
https://bugs.webkit.org/show_bug.cgi?id=207715
Comment 5 Brent Fulgham 2022-02-12 19:52:15 PST 

*** This bug has been marked as a duplicate of bug 207715 ***