Bug 186705 - StyleRuleMedia wastes 158KB of Vector capacity on cnn.com
Summary: StyleRuleMedia wastes 158KB of Vector capacity on cnn.com
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-15 15:07 PDT by Simon Fraser (smfr)
Modified: 2018-06-15 18:59 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.47 KB, patch)
2018-06-15 16:55 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2018-06-15 15:07:11 PDT 
Tooling from bug 186698:

Wasted capacity: 158008 bytes (used 16128 of 174136 bytes, utilization: 9.26%) - 1356 allocations
1   0x1074c1355 WTF::VectorBuffer<WTF::RefPtr<WebCore::StyleRuleBase, WTF::DumbPtrTraits<WebCore::StyleRuleBase> >, 0ul>::VectorBuffer()
2   0x1074c1335 WTF::Vector<WTF::RefPtr<WebCore::StyleRuleBase, WTF::DumbPtrTraits<WebCore::StyleRuleBase> >, 0ul, WTF::CrashOnOverflow, 16ul>::Vector()
3   0x107497385 WTF::Vector<WTF::RefPtr<WebCore::StyleRuleBase, WTF::DumbPtrTraits<WebCore::StyleRuleBase> >, 0ul, WTF::CrashOnOverflow, 16ul>::Vector()
4   0x1074972da WebCore::StyleRuleGroup::StyleRuleGroup(WebCore::StyleRuleBase::Type, WTF::Vector<WTF::RefPtr<WebCore::StyleRuleBase, WTF::DumbPtrTraits<WebCore::StyleRuleBase> >, 0ul, WTF::CrashOnOverflow, 16ul>&)
5   0x1074980cd WebCore::StyleRuleMedia::StyleRuleMedia(WTF::Ref<WebCore::MediaQuerySet, WTF::DumbPtrTraits<WebCore::MediaQuerySet> >&&, WTF::Vector<WTF::RefPtr<WebCore::StyleRuleBase, WTF::DumbPtrTraits<WebCore::StyleRuleBase> >, 0ul, WTF::CrashOnOverflow, 16ul>&)
6   0x107498125 WebCore::StyleRuleMedia::StyleRuleMedia(WTF::Ref<WebCore::MediaQuerySet, WTF::DumbPtrTraits<WebCore::MediaQuerySet> >&&, WTF::Vector<WTF::RefPtr<WebCore::StyleRuleBase, WTF::DumbPtrTraits<WebCore::StyleRuleBase> >, 0ul, WTF::CrashOnOverflow, 16ul>&)
7   0x1074de618 WebCore::StyleRuleMedia::create(WTF::Ref<WebCore::MediaQuerySet, WTF::DumbPtrTraits<WebCore::MediaQuerySet> >&&, WTF::Vector<WTF::RefPtr<WebCore::StyleRuleBase, WTF::DumbPtrTraits<WebCore::StyleRuleBase> >, 0ul, WTF::CrashOnOverflow, 16ul>&)
8   0x1074dc1d8 WebCore::CSSParserImpl::consumeMediaRule(WebCore::CSSParserTokenRange, WebCore::CSSParserTokenRange)
Comment 1 Radar WebKit Bug Importer 2018-06-15 15:07:40 PDT 
<rdar://problem/41173637>
Comment 2 Chris Dumez 2018-06-15 16:55:55 PDT 
Created attachment 342857 [details]
Patch
Comment 3 WebKit Commit Bot 2018-06-15 18:59:48 PDT 
Comment on attachment 342857 [details]
Patch

Clearing flags on attachment: 342857

Committed r232899: <https://trac.webkit.org/changeset/232899>
Comment 4 WebKit Commit Bot 2018-06-15 18:59:50 PDT 
All reviewed patches have been landed.  Closing bug.