Bug 186700 - StyleRuleGroup wastes 80KB of Vector capacity
Summary: StyleRuleGroup wastes 80KB of Vector capacity
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-15 15:00 PDT by Simon Fraser (smfr)
Modified: 2018-06-15 15:01 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2018-06-15 15:00:10 PDT 
Using the tooling from bug 186698:

Wasted capacity: 76912 bytes (used 12088 of 89000 bytes, utilization: 13.58%) - 683 allocations
1   0x1074c1355 WTF::VectorBuffer<WTF::RefPtr<WebCore::StyleRuleBase, WTF::DumbPtrTraits<WebCore::StyleRuleBase> >, 0ul>::VectorBuffer()
2   0x1074c1335 WTF::Vector<WTF::RefPtr<WebCore::StyleRuleBase, WTF::DumbPtrTraits<WebCore::StyleRuleBase> >, 0ul, WTF::CrashOnOverflow, 16ul>::Vector()
3   0x107497385 WTF::Vector<WTF::RefPtr<WebCore::StyleRuleBase, WTF::DumbPtrTraits<WebCore::StyleRuleBase> >, 0ul, WTF::CrashOnOverflow, 16ul>::Vector()
4   0x1074972da WebCore::StyleRuleGroup::StyleRuleGroup(WebCore::StyleRuleBase::Type, WTF::Vector<WTF::RefPtr<WebCore::StyleRuleBase, WTF::DumbPtrTraits<WebCore::StyleRuleBase> >, 0ul, WTF::CrashOnOverflow, 16ul>&)
5   0x1074980cd WebCore::StyleRuleMedia::StyleRuleMedia(WTF::Ref<WebCore::MediaQuerySet, WTF::DumbPtrTraits<WebCore::MediaQuerySet> >&&, WTF::Vector<WTF::RefPtr<WebCore::StyleRuleBase, WTF::DumbPtrTraits<WebCore::StyleRuleBase> >, 0ul, WTF::CrashOnOverflow, 16ul>&)
6   0x107498125 WebCore::StyleRuleMedia::StyleRuleMedia(WTF::Ref<WebCore::MediaQuerySet, WTF::DumbPtrTraits<WebCore::MediaQuerySet> >&&, WTF::Vector<WTF::RefPtr<WebCore::StyleRuleBase, WTF::DumbPtrTraits<WebCore::StyleRuleBase> >, 0ul, WTF::CrashOnOverflow, 16ul>&)
7   0x1074de618 WebCore::StyleRuleMedia::create(WTF::Ref<WebCore::MediaQuerySet, WTF::DumbPtrTraits<WebCore::MediaQuerySet> >&&, WTF::Vector<WTF::RefPtr<WebCore::StyleRuleBase, WTF::DumbPtrTraits<WebCore::StyleRuleBase> >, 0ul, WTF::CrashOnOverflow, 16ul>&)
8   0x1074dc1d8 WebCore::CSSParserImpl::consumeMediaRule(WebCore::CSSParserTokenRange, WebCore::CSSParserTokenRange)
Comment 1 Radar WebKit Bug Importer 2018-06-15 15:01:28 PDT 
<rdar://problem/41173394>