Currently for text controls we are just setting their value directly to the input elements. We should mimic the keyboard typing process and send out key events.
<rdar://problem/41169985>
Created attachment 344249 [details] patch I think it would be more appropriate to dispatch InputEvent since we don't want to send out KeyboardEvent for each of the character in the value string.
Comment on attachment 344249 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=344249&action=review > Source/WebCore/ChangeLog:9 > + Use Editor's insertText function when the text control element is being this should be just one sentence. "Use the Editor's insertText function when the text control element is being, so that the InputEvent will be dispatched properly." > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1784 > + } should we make the following statement an else if so this follows the rest of the pattern and we can ditch the return;
Comment on attachment 344249 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=344249&action=review >> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1784 >> + } > > should we make the following statement an else if so this follows the rest of the pattern and we can ditch the return; This if checks the frame. But we still want to follow the rest of the pattern if the element is not in editing mode. So I think a return here is more appropriate.
Committed r233525: <https://trac.webkit.org/changeset/233525>
It looks like the new test: accessibility/Mac/set-value-editable-dispatch-events.html is flakey from the start. I have seen it fail on a few EWS patches. test History: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=accessibility%2Fmac%2Fset-value-editable-dispatch-events.html
Ok I will take a look
Created attachment 344390 [details] patch patch to fix the flaky test. I think the problem is that both clearText and insertText will dispatch input events. The event handling in the test can get messy in some of the machines. We should make sure handling all the input events before moving to the next test case.
Reopen to fix the flaky test
Created attachment 344391 [details] patch
Comment on attachment 344391 [details] patch Clearing flags on attachment: 344391 Committed r233580: <https://trac.webkit.org/changeset/233580>
All reviewed patches have been landed. Closing bug.