Bug 186686 - [ESNext] Symbol.prototype.description
Summary: [ESNext] Symbol.prototype.description
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ross Kirsling
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-15 12:35 PDT by Leo Balter
Modified: 2018-09-05 15:48 PDT (History)
10 users (show)

See Also:


Attachments
Patch (4.72 KB, patch)
2018-09-05 13:56 PDT, Ross Kirsling
no flags Details | Formatted Diff | Diff
Patch for landing (4.75 KB, patch)
2018-09-05 14:39 PDT, Ross Kirsling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Leo Balter 2018-06-15 12:35:41 PDT
Currently on Stage 3.

https://github.com/tc39/proposal-Symbol-description

On Test262 test/built-ins/Symbol/prototype/description using feature tag "Symbol.prototype.description"
Comment 1 Ross Kirsling 2018-09-05 13:56:11 PDT
Created attachment 348962 [details]
Patch
Comment 2 Keith Miller 2018-09-05 14:14:42 PDT
Comment on attachment 348962 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348962&action=review

> JSTests/stress/symbol-description.js:-22
> -var s1 = Symbol("Cappuccino");

Please put this one back. There's no reason to remove it as it's not like it makes anything measurably slower.
Comment 3 Keith Miller 2018-09-05 14:15:21 PDT
Other than the test lgtm.
Comment 4 Ross Kirsling 2018-09-05 14:39:50 PDT
Created attachment 348965 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2018-09-05 15:18:16 PDT
Comment on attachment 348965 [details]
Patch for landing

Clearing flags on attachment: 348965

Committed r235712: <https://trac.webkit.org/changeset/235712>
Comment 6 WebKit Commit Bot 2018-09-05 15:18:17 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-09-05 15:19:42 PDT
<rdar://problem/44156631>
Comment 8 Jordan Harband 2018-09-05 15:42:48 PDT
Presumably this will land in nightly tonight; when might it land in TP?
Comment 9 Ross Kirsling 2018-09-05 15:48:25 PDT
(In reply to Jordan Harband from comment #8)
> Presumably this will land in nightly tonight; when might it land in TP?

I believe it's every other Wednesday, so most likely 9/12?