Instead of DisplayRefreshMonitorMac having a RefPtr to WebPage, it should have a weak pointer. Having a RefPtr could in theory create reference cycles. I have not seen any cases of this, but I think it would be better design to hold a weak pointer.
Created attachment 342828 [details] Patch
<rdar://problem/41164502>
Comment on attachment 342828 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=342828&action=review r=me > Source/WebKit/ChangeLog:10 > + observed in practice, but it is safer to use a weak pointer. Good point!
Comment on attachment 342828 [details] Patch Thanks for reviewing!
Comment on attachment 342828 [details] Patch Clearing flags on attachment: 342828 Committed r232884: <https://trac.webkit.org/changeset/232884>
All reviewed patches have been landed. Closing bug.
Re-opened since this is blocked by bug 186891
Committed r234725: <https://trac.webkit.org/changeset/234725/webkit>