WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
186683
DisplayRefreshMonitorMac should hold a weak pointer to WebPage.
https://bugs.webkit.org/show_bug.cgi?id=186683
Summary
DisplayRefreshMonitorMac should hold a weak pointer to WebPage.
Per Arne Vollan
Reported
2018-06-15 10:42:40 PDT
Instead of DisplayRefreshMonitorMac having a RefPtr to WebPage, it should have a weak pointer. Having a RefPtr could in theory create reference cycles. I have not seen any cases of this, but I think it would be better design to hold a weak pointer.
Attachments
Patch
(3.12 KB, patch)
2018-06-15 10:48 PDT
,
Per Arne Vollan
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Per Arne Vollan
Comment 1
2018-06-15 10:48:40 PDT
Created
attachment 342828
[details]
Patch
Radar WebKit Bug Importer
Comment 2
2018-06-15 10:49:31 PDT
<
rdar://problem/41164502
>
Brent Fulgham
Comment 3
2018-06-15 11:00:06 PDT
Comment on
attachment 342828
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=342828&action=review
r=me
> Source/WebKit/ChangeLog:10 > + observed in practice, but it is safer to use a weak pointer.
Good point!
Per Arne Vollan
Comment 4
2018-06-15 11:05:35 PDT
Comment on
attachment 342828
[details]
Patch Thanks for reviewing!
WebKit Commit Bot
Comment 5
2018-06-15 11:47:39 PDT
Comment on
attachment 342828
[details]
Patch Clearing flags on attachment: 342828 Committed
r232884
: <
https://trac.webkit.org/changeset/232884
>
WebKit Commit Bot
Comment 6
2018-06-15 11:47:40 PDT
All reviewed patches have been landed. Closing bug.
WebKit Commit Bot
Comment 7
2018-06-21 13:21:10 PDT
Re-opened since this is blocked by
bug 186891
Per Arne Vollan
Comment 8
2018-08-09 08:50:41 PDT
Committed
r234725
: <
https://trac.webkit.org/changeset/234725/webkit
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug