Bug 186677 - REGRESSION (r232799): Form controls are blank in dark mode
Summary: REGRESSION (r232799): Form controls are blank in dark mode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-15 10:09 PDT by Timothy Hatcher
Modified: 2018-06-15 22:14 PDT (History)
5 users (show)

See Also:

Attachments
Bug (343.21 KB, image/png)
2018-06-15 10:09 PDT, Timothy Hatcher 		no flags Details
Patch (2.16 KB, patch)
2018-06-15 10:12 PDT, Timothy Hatcher 		no flags Details | Formatted Diff | Diff
With Patch (347.40 KB, image/png)
2018-06-15 10:15 PDT, Timothy Hatcher 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2018-06-15 10:09:02 PDT 
After fixing bug 186597, the controls in dark mode stopped rendering.
Comment 1 Radar WebKit Bug Importer 2018-06-15 10:09:16 PDT 
<rdar://problem/41162899>
Comment 2 Timothy Hatcher 2018-06-15 10:09:17 PDT 
Created attachment 342822 [details]
Bug
Comment 3 Timothy Hatcher 2018-06-15 10:12:37 PDT 
Created attachment 342823 [details]
Patch
Comment 4 Wenson Hsieh 2018-06-15 10:13:36 PDT 
Comment on attachment 342823 [details]
Patch

Thanks for catching this!
Comment 5 Timothy Hatcher 2018-06-15 10:15:35 PDT 
Created attachment 342824 [details]
With Patch
Comment 6 WebKit Commit Bot 2018-06-15 10:33:00 PDT 
Comment on attachment 342823 [details]
Patch

Clearing flags on attachment: 342823

Committed r232880: <https://trac.webkit.org/changeset/232880>
Comment 7 WebKit Commit Bot 2018-06-15 10:33:02 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Alexey Proskuryakov 2018-06-15 22:13:53 PDT 
Comment on attachment 342823 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342823&action=review

> Source/WebCore/ChangeLog:13
> +        Dark mode controls don't have borders, just a semi-transparent background of shadows.
> +        In the dark mode case we can't disable borders, or we will not paint anything for the control.

How do we regression test such things?