Bug 186675 - Rollout r231818, as it introduced regression on tickets.com.
Summary: Rollout r231818, as it introduced regression on tickets.com.
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
Keywords: InRadar
Depends on:
Reported: 2018-06-15 09:56 PDT by Per Arne Vollan
Modified: 2018-11-07 13:32 PST (History)
4 users (show)

See Also:

Patch (3.33 KB, patch)
2018-06-15 10:01 PDT, Per Arne Vollan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2018-06-15 09:56:16 PDT
Rollout https://trac.webkit.org/changeset/231818/webkit, as it introduced regression on tickets.com. This changeset would pause display links in background tasks, and when Safari is minimized. Perhaps we can throttle display links in background tabs instead? This changeset is also not needed to fix the associated bug https://bugs.webkit.org/show_bug.cgi?id=185627 anymore, since this was fixed by https://trac.webkit.org/changeset/232563.
Comment 1 Per Arne Vollan 2018-06-15 09:57:25 PDT
Comment 2 Per Arne Vollan 2018-06-15 10:01:37 PDT
Created attachment 342821 [details]
Comment 3 WebKit Commit Bot 2018-06-15 10:32:55 PDT
Comment on attachment 342821 [details]

Clearing flags on attachment: 342821

Committed r232879: <https://trac.webkit.org/changeset/232879>
Comment 4 WebKit Commit Bot 2018-06-15 10:32:56 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Simon Fraser (smfr) 2018-11-07 10:49:17 PST
Won't this be a power regression?
Comment 6 Per Arne Vollan 2018-11-07 13:32:47 PST
(In reply to Simon Fraser (smfr) from comment #5)
> Won't this be a power regression?

I don't believe so, since starting/stopping a display link is controlled by cross-platform code by creating/deleting a DisplayRefreshMonitor.