Bug 186632 - Add a graceful exit for AuthenticationManager::initializeConnection
Summary: Add a graceful exit for AuthenticationManager::initializeConnection
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jiewen Tan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-14 14:22 PDT by Jiewen Tan
Modified: 2018-08-15 15:38 PDT (History)
13 users (show)

See Also:

Attachments
Patch (3.12 KB, patch)
2018-06-14 14:28 PDT, Jiewen Tan 		bfulgham: review+
Details | Formatted Diff | Diff
Archive of layout-test-results from ltilve-gtk-wk2-ews for gtk-wk2 (2.67 MB, application/zip)
2018-06-14 19:50 PDT, Igalia-pontevedra EWS 		no flags Details
Patch for landing (3.13 KB, patch)
2018-06-18 11:10 PDT, Jiewen Tan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jiewen Tan 2018-06-14 14:22:37 PDT 
Add a grace exit for AuthenticationManager::initializeConnection when the provided IPC connection is null or the underlying xpc connection is null.
Comment 1 Jiewen Tan 2018-06-14 14:23:10 PDT 
<rdar://problem/41041033>
Comment 2 Jiewen Tan 2018-06-14 14:28:10 PDT 
Created attachment 342761 [details]
Patch
Comment 3 Igalia-pontevedra EWS 2018-06-14 19:50:52 PDT 
Comment on attachment 342761 [details]
Patch

Attachment 342761 [details] did not pass gtk-wk2-ews (gtk-wk2):
Output: http://webkit-queues.webkit.org/results/8189070

New failing tests:
http/tests/misc/char-encoding-bocu-1-blacklisted.html
Comment 4 Igalia-pontevedra EWS 2018-06-14 19:50:57 PDT 
Created attachment 342786 [details]
Archive of layout-test-results from ltilve-gtk-wk2-ews for gtk-wk2

The attached test failures were seen while running run-webkit-tests on the gtk-wk2-ews.
Bot: ltilve-gtk-wk2-ews  Port: gtk-wk2  Platform: Linux-4.16.0-0.bpo.1-amd64-x86_64-with-debian-9.4
Comment 5 Jiewen Tan 2018-06-15 11:11:59 PDT 
The tree of GTK EWS Port is red.
Comment 6 Brent Fulgham 2018-06-18 10:14:55 PDT 
Comment on attachment 342761 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342761&action=review

r=me.

> Source/WebKit/ChangeLog:3
> +        Add a grace exit for AuthenticationManager::initializeConnection

Add a graceful exit ...

> Source/WebKit/ChangeLog:9
> +        Add a grace exit for AuthenticationManager::initializeConnection when the provided IPC connection

Ditto.
Comment 7 Jiewen Tan 2018-06-18 11:06:51 PDT 
Comment on attachment 342761 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342761&action=review

Thanks Brent for r+ this patch.

>> Source/WebKit/ChangeLog:3
>> +        Add a grace exit for AuthenticationManager::initializeConnection
> 
> Add a graceful exit ...

Fixed.

>> Source/WebKit/ChangeLog:9
>> +        Add a grace exit for AuthenticationManager::initializeConnection when the provided IPC connection
> 
> Ditto.

Fixed.
Comment 8 Jiewen Tan 2018-06-18 11:10:24 PDT 
Created attachment 342953 [details]
Patch for landing
Comment 9 WebKit Commit Bot 2018-06-18 11:54:56 PDT 
Comment on attachment 342953 [details]
Patch for landing

Clearing flags on attachment: 342953

Committed r232937: <https://trac.webkit.org/changeset/232937>