Bug 186606 - Web Inspector: open source Dark Mode
Summary: Web Inspector: open source Dark Mode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-13 13:07 PDT by Nikita Vasilyev
Modified: 2018-06-13 14:26 PDT (History)
4 users (show)

See Also:

Attachments
Patch (52.49 KB, patch)
2018-06-13 13:16 PDT, Nikita Vasilyev 		no flags Details | Formatted Diff | Diff
Patch (53.84 KB, patch)
2018-06-13 13:22 PDT, Nikita Vasilyev 		timothy: review+
Details | Formatted Diff | Diff
Patch (53.62 KB, patch)
2018-06-13 13:47 PDT, Nikita Vasilyev 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2018-06-13 13:07:56 PDT 
Safari Developer Tools on macOS Mojave support a dark mode. Make it publicly available as a part of the WebKit repository.

<rdar://problem/41027067>
Comment 1 Nikita Vasilyev 2018-06-13 13:16:44 PDT 
Created attachment 342687 [details]
Patch
Comment 2 Nikita Vasilyev 2018-06-13 13:22:14 PDT 
Created attachment 342688 [details]
Patch

Add the license header.
Comment 3 Timothy Hatcher 2018-06-13 13:38:27 PDT 
Comment on attachment 342688 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342688&action=review

> Source/WebInspectorUI/UserInterface/Main.html:240
> +    <link rel="stylesheet" href="Views/DarkMode.css">

It would be good to merge the rules into the other files for ease of maintenance in a future patch.

> Source/WebInspectorUI/UserInterface/Main.html:-243
> -    <link rel="stylesheet" href="WebKitAdditions/WebInspectorUI/WebInspectorUIAdditions.css">

Might as well keep this line, in case we need it in the future.
Comment 4 Nikita Vasilyev 2018-06-13 13:47:38 PDT 
Created attachment 342690 [details]
Patch

(In reply to Timothy Hatcher from comment #3)
> Comment on attachment 342688 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=342688&action=review
> 
> > Source/WebInspectorUI/UserInterface/Main.html:240
> > +    <link rel="stylesheet" href="Views/DarkMode.css">
> 
> It would be good to merge the rules into the other files for ease of
> maintenance in a future patch.

Yes, that's the plan!
Comment 5 WebKit Commit Bot 2018-06-13 14:26:41 PDT 
Comment on attachment 342690 [details]
Patch

Clearing flags on attachment: 342690

Committed r232811: <https://trac.webkit.org/changeset/232811>
Comment 6 WebKit Commit Bot 2018-06-13 14:26:43 PDT 
All reviewed patches have been landed.  Closing bug.