RESOLVED FIXED 186592
[JSC] Always use Nuke & Set procedure for x86 
https://bugs.webkit.org/show_bug.cgi?id=186592
Summary [JSC] Always use Nuke & Set procedure for x86
Yusuke Suzuki
Reported 2018-06-13 08:52:45 PDT
[JSC] Always use Nuke & Set procedure for x86
Attachments
Patch (2.89 KB, patch)
2018-06-13 08:54 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2018-06-13 08:54:33 PDT
Created attachment 342662 [details] Patch
Keith Miller
Comment 2 2018-06-13 10:05:21 PDT
Comment on attachment 342662 [details] Patch r=me.
Yusuke Suzuki
Comment 3 2018-06-13 11:06:13 PDT
Comment on attachment 342662 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=342662&action=review Thank you! > Source/JavaScriptCore/runtime/JSObject.cpp:1365 > + locker = holdLock(cellLock()); I’m discussing right now whether this lock can be removed. Anyway, this patch itself is unrelated to that since this still holds the lock. I’ll land this one.
WebKit Commit Bot
Comment 4 2018-06-13 11:33:02 PDT
Comment on attachment 342662 [details] Patch Clearing flags on attachment: 342662 Committed r232798: <https://trac.webkit.org/changeset/232798>
WebKit Commit Bot
Comment 5 2018-06-13 11:33:04 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-06-13 12:29:22 PDT
<rdar://problem/41097196>
Note You need to log in before you can comment on or make changes to this bug.