Bug 186592 - [JSC] Always use Nuke & Set procedure for x86
Summary: [JSC] Always use Nuke & Set procedure for x86
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-13 08:52 PDT by Yusuke Suzuki
Modified: 2018-06-13 12:29 PDT (History)
7 users (show)

See Also:

Attachments
Patch (2.89 KB, patch)
2018-06-13 08:54 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2018-06-13 08:52:45 PDT 
[JSC] Always use Nuke & Set procedure for x86
Comment 1 Yusuke Suzuki 2018-06-13 08:54:33 PDT 
Created attachment 342662 [details]
Patch
Comment 2 Keith Miller 2018-06-13 10:05:21 PDT 
Comment on attachment 342662 [details]
Patch

r=me.
Comment 3 Yusuke Suzuki 2018-06-13 11:06:13 PDT 
Comment on attachment 342662 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342662&action=review

Thank you!

> Source/JavaScriptCore/runtime/JSObject.cpp:1365
> +        locker = holdLock(cellLock());

I’m discussing right now whether this lock can be removed. Anyway, this patch itself is unrelated to that since this still holds the lock. I’ll land this one.
Comment 4 WebKit Commit Bot 2018-06-13 11:33:02 PDT 
Comment on attachment 342662 [details]
Patch

Clearing flags on attachment: 342662

Committed r232798: <https://trac.webkit.org/changeset/232798>
Comment 5 WebKit Commit Bot 2018-06-13 11:33:04 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-06-13 12:29:22 PDT 
<rdar://problem/41097196>