The following feature is not related to WorkQueue's purpose and only used in IPC::Connection for WebKit Windows. It should be moved there until others actually need that feature. > (WTF::WorkQueue::handleCallback): > (WTF::WorkQueue::registerHandle): > (WTF::WorkQueue::unregisterAndCloseHandle):
Created attachment 342715 [details] PATCH
Attachment 342715 [details] did not pass style-queue: ERROR: Source/WebKit/Platform/IPC/win/ConnectionWin.cpp:357: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/Platform/IPC/win/ConnectionWin.cpp:357: Missing space inside { }. [whitespace/braces] [5] Total errors found: 2 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 342715 [details] PATCH View in context: https://bugs.webkit.org/attachment.cgi?id=342715&action=review Looks nice to me. I want Windows reviewer's r+ too. > Source/WebKit/Platform/IPC/win/ConnectionWin.cpp:345 > + // Connection::platformInvalidate. => EventListener::close(). > Source/WebKit/Platform/IPC/win/ConnectionWin.cpp:348 > + // And do not ::CloseHandle(waitHandle). => m_waitHandle.
Created attachment 342751 [details] PATCH Thanks Yusuke.
Created attachment 342764 [details] FIX
Looks good!
Comment on attachment 342764 [details] FIX Clearing flags on attachment: 342764 Committed r232888: <https://trac.webkit.org/changeset/232888>
All reviewed patches have been landed. Closing bug.
<rdar://problem/41168126>